Bug #59582: snap-schedule: allow retention spec to specify max number of snaps to retain - CephFS - Ceph

Actions

Copy link

Bug #59582

closed

snap-schedule: allow retention spec to specify max number of snaps to retain

Added by Milind Changire about 1 year ago. Updated about 2 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Milind Changire

Category:

Administration/Usability

Target version:

Ceph - v19.0.0

% Done:

Source:

Tags:

backport_processed

Backport:

reef,quincy,pacific

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

mgr/snap_schedule

Labels (FS):

Pull request ID:

51278

Crash signature (v1):

Crash signature (v2):

Description

Along with daily, weekly, monthly and yearly snaps, users also need a way to mention the max number of snaps they need to retain if they feel that MAX_SNAPS_PER_PATH (50) is insufficient for their purpose.

eg. the new snap-schedule with the retention spec could be: /PATH 1d1m 75n

where a max of 75 snaps from the 1d1m snap-schedule will be retained. If number of snaps ('n') are not specified as the retention spec then the default of MAX_SNAPS_PER_PATH (50) should be applicable.

NOTE: the max number of snaps possible are also a function of the system-wide config named mds_max_snaps_per_dir, which currently defaults to 100

So, if the number of snaps for a path/dir that need to be created exceeds 100, then a user would first need to tweak the value for mds_max_snaps_per_dir before updating the snap-schedule retention spec beyond 100.

NOTE: Since mds_max_snaps_per_dir is a run-time system-wide spec, any change to that config will immediately affect existing snap-schedule retention specs.

Related issues 3 (0 open — 3 closed)