Project

General

Profile

Actions
Copy link

Bug #59096

closed

CLOCK_REALTIME_COARSE overridden on Windows

Added by Lucian Petrut about 1 year ago. Updated 12 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Lucian Petrut
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
reef quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
50559
Crash signature (v1):
Crash signature (v2):

Description

mingw < 8.0.0 didn't define CLOCK_REALTIME_COARSE, which is why ceph_time.h is defining it as CLOCK_REALTIME.

mingw >= 8.0.1 adds CLOCK_REALTIME_COARSE and improves the CEPH_REALTIME precision [1].

This basically means that when building ceph with mingw >= 8.0,1, ceph::coarse_real_clock uses the high precision function, which can incur unnecessary overhead [2].

We'll need to avoid overriding CEPH_REALTIME_COARSE when already defined.

[1] https://github.com/mirror/mingw-w64/commit/dcd990ed423381cf35702df9495d44f1979ebe50
[2] https://github.com/microsoft/STL/issues/624#issuecomment-603001670

Related issues 2 (0 open — 2 closed)

Copied to Ceph - Backport #59097: quincy: CLOCK_REALTIME_COARSE overridden on WindowsResolvedLucian PetrutActions
Copied to Ceph - Backport #59098: reef: CLOCK_REALTIME_COARSE overridden on WindowsResolvedLucian PetrutActions
Actions
Copy link
 #1

Updated by Lucian Petrut about 1 year ago

  • Copied to Backport #59097: quincy: CLOCK_REALTIME_COARSE overridden on Windows added
Actions
Copy link
 #2

Updated by Lucian Petrut about 1 year ago

  • Tags set to backport_processed
Actions
Copy link
 #3

Updated by Lucian Petrut about 1 year ago

  • Copied to Backport #59098: reef: CLOCK_REALTIME_COARSE overridden on Windows added
Actions
Copy link
 #4

Updated by Ilya Dryomov 12 months ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF