Project

General

Profile

Actions

Feature #543

closed

PG::search_for_missing: don't iterate over all missing

Added by Colin McCabe over 13 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

PG::search_for_missing processes a replica's missing map to determine if it has any objects that we need.

If the missing set becomes very large, this could get very time-consuming. Instead, we probably want to just iterate over our unfound set. (Objects we know about but don't know where to find.)

This would involve tracking the unfound set separately (need a fast way to iterate over that). It also involves changing the retry logic in pull so that we can figure out some new locations to pull from when pulling from the first location fails. After all, the whole reason we try to find every location now is because pulling from some of them may not work (in theory.)

This seems fairly low priority but I'm making a note.

Actions #1

Updated by Sage Weil over 13 years ago

  • Estimated time set to 8:00 h
  • Source set to 5
Actions #2

Updated by Sage Weil over 12 years ago

  • Target version set to 19
Actions #3

Updated by Sage Weil over 12 years ago

  • Target version deleted (19)
Actions #4

Updated by Sage Weil over 12 years ago

  • Translation missing: en.field_position deleted (363)
  • Translation missing: en.field_position set to 842
Actions #5

Updated by Sage Weil over 12 years ago

  • Translation missing: en.field_position deleted (850)
  • Translation missing: en.field_position set to 1
  • Translation missing: en.field_position changed from 1 to 860
Actions #6

Updated by Loïc Dachary over 9 years ago

  • Status changed from New to Resolved

The code base changed significantly and does not have this problem anymore.

Actions

Also available in: Atom PDF