Ceph » mgr » Dashboard

make check is failing at mgr-dashboard-frontend-unittests

Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.
  ● Test suite failed to run

    src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.spec.ts:7:30 - error TS2307: Cannot find module 'app/shared/components/select/select-option.model' or its corresponding type declarations.

    7 import { SelectOption } from 'app/shared/components/select/select-option.model';

It's likely that this error was introduced by this PR: https://github.com/ceph/ceph/pull/37198 :

• How was it possible for that to pass CI? Because last make check run is from Oct 22, so later changes merged would have caused this to break.
• Lesson learnt: on stale PR's (more than a week old) we should always retrigger checks prior to merging.
• Additionally, a post-merge build could help quickly identify breakages.