Ceph » rbd

I think it may be hard to describe exactly what the problems
of this type are. I do a fairly good job of it in the patch
descriptions though, and it would be nice if I could simply
refer to those for further information.

Anyway, one of the things I'm doing as I review the code is
making sure functions never change any externally-visible
state until/unless they are going to return success. These
are very minor changes--in a lot of cases just holding values
in local variables until we know we'll succeed and then making
externally-visible assignments from the locals after that.
That sort of fits here, so I guess I'll try to record things
of that type here as I find them.

I just posted a series of patches for review, and at least one
of them (3/6) is of that type.

[PATCH 1/6] rbd: fix leak of snapshots during initial probe
[PATCH 2/6] rbd: make snap_size order parameter optional
[PATCH 3/6] rbd: only update values on snap_info success
[PATCH 4/6] rbd: rename __rbd_add_snap_dev()
[PATCH 5/6] rbd: fix leak of format 2 snapshot names
[PATCH 6/6] rbd: use rbd_obj_method_sync() return value

I also mention these patches in and marked "need review"
this issue: http://tracker.ceph.com/issues/4802