Bug #43084
closedstd:random_shuffle is depricated in C++17
0%
Description
see:
https://en.cppreference.com/w/cpp/algorithm/random_shuffle
And this fails on FreeBSD/Clang/stdlibc++
/home/jenkins/workspace/ceph-master/src/tools/osdmaptool.cc:437:5: error: use of undeclared identifier 'random_shuffle'
random_shuffle (rules.begin(), rules.end());
^
1 error generated.
gmake2: * [src/tools/CMakeFiles/osdmaptool.dir/build.make:63: src/tools/CMakeFiles/osdmaptool.dir/osdmaptool.cc.o] Error 1
gmake2: Leaving directory '/home/jenkins/workspace/ceph-master/build'
gmake1: * [CMakeFiles/Makefile2:5960: src/tools/CMakeFiles/osdmaptool.dir/all] Error 2
Updated by Kefu Chai over 4 years ago
- Status changed from New to Fix Under Review
- Pull request ID changed from 31935 to 31944
Updated by Nathan Cutler over 4 years ago
Note: backporting being handled via #42718 because this is a follow-on fix for https://github.com/ceph/ceph/pull/31774/commits/b946308f03f1798915fafe7878f34b4a234c2ae4 which was part of that fix.
Updated by Nathan Cutler over 4 years ago
- Related to Bug #42718: Improve OSDMap::calc_pg_upmaps() efficiency added
Updated by Nathan Cutler over 4 years ago
- Status changed from Fix Under Review to Resolved
Updated by David Zafman over 4 years ago
- Status changed from Resolved to In Progress
- Assignee set to David Zafman
- Backport set to luminous, mimic, nautilus
Updated by David Zafman over 4 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID changed from 31944 to 31990
Updated by David Zafman over 4 years ago
- Backport deleted (
luminous, mimic, nautilus)
This will be back ported with 42718 so it doesn't need entry in "Backport" field.
Updated by Kefu Chai over 4 years ago
- Status changed from Fix Under Review to Resolved