Bug #4240
closed
libceph: fix a osd request memory leak
Added by Alex Elder about 11 years ago.
Updated about 11 years ago.
Description
If an invalid layout is provided to ceph_osdc_new_request(), its
call to calc_layout() might return an error. At that point in the
function we've already allocated an osd request structure, so we
need to free it (drop a reference) in the event such an error
occurs.
The only other value calc_layout() will return is 0, so make that
explicit in the successful case.
Signed-off-by: Alex Elder <elder@inktank.com>
- Status changed from In Progress to Fix Under Review
This has been posted for review.
[PATCH] libceph: fix a osd request memory leak
- Status changed from Fix Under Review to Resolved
This was committed recently and I neglected to close this.
commit 6b3c5cdf66da552096b165a50dbd5313759a6ea6
Author: Alex Elder <elder@inktank.com>
Date: Fri Feb 15 22:10:17 2013 -0600
libceph: fix a osd request memory leak
If an invalid layout is provided to ceph_osdc_new_request(), its
call to calc_layout() might return an error. At that point in the
function we've already allocated an osd request structure, so we
need to free it (drop a reference) in the event such an error
occurs.
The only other value calc_layout() will return is 0, so make that
explicit in the successful case.
This resolves:
http://tracker.ceph.com/issues/4240
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
Also available in: Atom
PDF