Actions
Feature #4215
closedmds: support setfattr on ceph.dir.layout
% Done:
0%
Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Description
gregf@kai:~/ceph/src/mnt$ mkdir tmp1 gregf@kai:~/ceph/src/mnt$ setfattr -n ceph.dir.layout -v "stripe_unit=2097152 stripe_count=1 object_size=2097152 pool=data" tmp1/ gregf@kai:~/ceph/src/mnt$ getfattr -n ceph.dir.layout tmp1/ # file: tmp1/ ceph.dir.layout="stripe_unit=4194304 stripe_count=1 object_size=4194304 pool=data"
Perhaps it's not the right format, despite being copied-and-pasted? But it still needs to return a failure instead of pretending to succeed. :(
This is on bobtail branch, with an in-progress layout storage change, so maybe it's part of that. But setting individual fields works fine:
gregf@kai:~/ceph/src/mnt$ setfattr -n ceph.dir.layout.stripe_unit -v "2097152" tmp1/ gregf@kai:~/ceph/src/mnt$ getfattr -n ceph.dir.layout tmp1/ # file: tmp1/ ceph.dir.layout="stripe_unit=2097152 stripe_count=1 object_size=4194304 pool=data"
Updated by Greg Farnum about 11 years ago
- Tracker changed from Bug to Feature
- Subject changed from mds: setfattr on ceph.dir.layout fails to change layout but returns success to mds: support setfattr on ceph.dir.layout
Oh, and indeed, looking at the source code:
if (name == "layout") {
// XXX implement me
} else if (name == "layout.object_size") {
I'll add a patch which disables this until we have an implementation.
Updated by Greg Farnum about 11 years ago
- Priority changed from High to Normal
Oh, as a feature this isn't any particular priority. Just an optimization, really.
Updated by Greg Farnum about 11 years ago
- Status changed from New to Resolved
- Assignee set to Sage Weil
Ah, it was just a lost commit! Resolved by commit:5551aa5b3b5c2e9e7006476b9cd8cc181d2c9a04, among others.
(It will probably go into bobtail as commit:b4fd196cae5ab76aeb8f82f0581d0a6a2133a3ed)
Actions