Project

General

Profile

Fix #4192

osd: fix log trimming

Added by Sage Weil over 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OSD
Target version:
Start date:
02/19/2013
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

We should trim the log even when we're degraded.

Define 'osd pg max log' or similar to control how big we let it get before trimming. Keeping it longer is good because it allows recovery for a temporarily-down replica, but it can't be allowed to grow indefinitely.


Related issues

Related to Ceph - Bug #4116: common/HeartbeatMap.cc: 79: FAILED assert(0 == "hit suicide timeout") Resolved 02/13/2013

History

#1 Updated by Greg Farnum over 6 years ago

I thought not trimming the log was a deliberate choice for faster catchup. Sounds like we need to define a better policy for when to trim and when not to, but don't just flip/erase a switch, right?

#2 Updated by Sage Weil over 6 years ago

  • Description updated (diff)

#3 Updated by Sage Weil over 6 years ago

  • translation missing: en.field_story_points set to 5.00

#4 Updated by Sage Weil about 6 years ago

  • Status changed from New to In Progress

#5 Updated by Sage Weil about 6 years ago

  • Target version set to v0.59

#6 Updated by Sage Weil about 6 years ago

  • Assignee set to Sage Weil

#7 Updated by Sage Weil about 6 years ago

  • Status changed from In Progress to Resolved

#8 Updated by Evan Felix about 6 years ago

This code fix seems to have disappeared in version v0.58

#9 Updated by Sage Weil about 6 years ago

It's not in v0.57 either, but is queued for v0.59 (out monday). Pushed wip-log-4192 based on v0.58 that includes the 3 patches that you can use in the meantime!

Also available in: Atom PDF