Project

General

Profile

Actions

Bug #41292

closed

regression: [filestore,bluestore] single type strategies fail after tracking devices as sets

Added by Jan Fajerski almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The super constructor still passes lists as default arguments. I think its actually better to only cast to sets for the _ensure_disjoint_device_list test.

Traceback (most recent call last):
  File "/sbin/ceph-volume", line 9, in <module>
    load_entry_point('ceph-volume==1.0.0', 'console_scripts', 'ceph-volume')()
  File "/usr/lib/python2.7/site-packages/ceph_volume/main.py", line 38, in __init__
    self.main(self.argv)
  File "/usr/lib/python2.7/site-packages/ceph_volume/decorators.py", line 59, in newfunc
    return f(*a, **kw)
  File "/usr/lib/python2.7/site-packages/ceph_volume/main.py", line 148, in main
    terminal.dispatch(self.mapper, subcommand_args)
  File "/usr/lib/python2.7/site-packages/ceph_volume/terminal.py", line 205, in dispatch
    instance.main()
  File "/usr/lib/python2.7/site-packages/ceph_volume/devices/lvm/main.py", line 40, in main
    terminal.dispatch(self.mapper, self.argv)
  File "/usr/lib/python2.7/site-packages/ceph_volume/terminal.py", line 205, in dispatch
    instance.main()
  File "/usr/lib/python2.7/site-packages/ceph_volume/decorators.py", line 16, in is_root
    return func(*a, **kw)
  File "/usr/lib/python2.7/site-packages/ceph_volume/devices/lvm/batch.py", line 318, in main
    self._get_explicit_strategy()
  File "/usr/lib/python2.7/site-packages/ceph_volume/devices/lvm/batch.py", line 351, in _get_explicit_strategy
    self.usable)
  File "/usr/lib/python2.7/site-packages/ceph_volume/devices/lvm/strategies/filestore.py", line 32, in __init__
    super(SingleType, self).__init__(args, data_devs)
  File "/usr/lib/python2.7/site-packages/ceph_volume/devices/lvm/strategies/strategies.py", line 15, in __init__
    self.devices = data_devs + wal_devs + db_or_journal_devs
TypeError: unsupported operand type(s) for +: 'set' and 'list'

Related issues 2 (0 open2 closed)

Copied to ceph-volume - Backport #41307: mimic: regression: [filestore,bluestore] single type strategies fail after tracking devices as setsResolvedJan FajerskiActions
Copied to ceph-volume - Backport #41308: nautilus: regression: [filestore,bluestore] single type strategies fail after tracking devices as setsResolvedJan FajerskiActions
Actions #1

Updated by Jan Fajerski almost 5 years ago

  • Description updated (diff)
Actions #2

Updated by Jan Fajerski almost 5 years ago

  • Pull request ID set to 29683
Actions #3

Updated by Jan Fajerski almost 5 years ago

  • Status changed from In Progress to Pending Backport
  • Backport set to nautilus, mimic
Actions #4

Updated by Jan Fajerski almost 5 years ago

  • Copied to Backport #41307: mimic: regression: [filestore,bluestore] single type strategies fail after tracking devices as sets added
Actions #5

Updated by Jan Fajerski almost 5 years ago

  • Copied to Backport #41308: nautilus: regression: [filestore,bluestore] single type strategies fail after tracking devices as sets added
Actions #6

Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved".

Actions

Also available in: Atom PDF