Project

General

Profile

Actions

Bug #38346

closed

luminous->nautilus: test_rbd.TestClone.test_unprotect_with_children: AssertionError: ImageBusy not raised

Added by Sage Weil about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

(gdb) bt
#0  __GI___pthread_mutex_lock (mutex=0x38) at ../nptl/pthread_mutex_lock.c:65
#1  0x00007f6051b8b1f1 in __gthread_mutex_lock (__mutex=0x38) at /usr/include/x86_64-linux-gnu/c++/7/bits/gthr-default.h:748
#2  std::mutex::lock (this=0x38) at /usr/include/c++/7/bits/std_mutex.h:103
#3  std::unique_lock<std::mutex>::lock (this=0x7ffd1ac992c0) at /usr/include/c++/7/bits/std_mutex.h:267
#4  std::unique_lock<std::mutex>::unique_lock (__m=..., this=0x7ffd1ac992c0) at /usr/include/c++/7/bits/std_mutex.h:197
#5  ceph::logging::Log::submit_entry (this=0x0, e=...) at ./src/log/Log.cc:177
#6  0x00007f604e08e4b1 in librbd::Watcher::block_notifies (this=this@entry=0x7f6028019350, on_finish=on_finish@entry=0x55f96d4baca0) at ./src/librbd/Watcher.cc:197
#7  0x00007f604e0363d1 in librbd::ImageWatcher<librbd::ImageCtx>::block_notifies (this=this@entry=0x7f6028019350, on_finish=0x55f96d4baca0) at ./src/librbd/ImageWatcher.cc:104
#8  0x00007f604e11cde8 in librbd::image::CloseRequest<librbd::ImageCtx>::send_block_image_watcher (this=this@entry=0x55f96d081990) at ./src/librbd/image/CloseRequest.cc:51
#9  0x00007f604e11d035 in librbd::image::CloseRequest<librbd::ImageCtx>::send (this=this@entry=0x55f96d081990) at ./src/librbd/image/CloseRequest.cc:37
#10 0x00007f604e025faf in librbd::ImageState<librbd::ImageCtx>::send_close_unlock (this=0x55f96d4293b0) at ./src/librbd/ImageState.cc:618
#11 0x00007f604e0268d5 in librbd::ImageState<librbd::ImageCtx>::execute_next_action_unlock (this=this@entry=0x55f96d4293b0) at ./src/librbd/ImageState.cc:520
#12 0x00007f604e026999 in librbd::ImageState<librbd::ImageCtx>::execute_action_unlock (this=this@entry=0x55f96d4293b0, action=..., on_finish=on_finish@entry=0x7ffd1ac99620) at ./src/librbd/ImageState.cc:542
#13 0x00007f604e027551 in librbd::ImageState<librbd::ImageCtx>::close (this=this@entry=0x55f96d4293b0, on_finish=on_finish@entry=0x7ffd1ac99620) at ./src/librbd/ImageState.cc:293
#14 0x00007f604e027762 in librbd::ImageState<librbd::ImageCtx>::close (this=0x55f96d4293b0) at ./src/librbd/ImageState.cc:276
#15 0x00007f604dfe2c33 in rbd_close (image=0x55f96d49dff0) at ./src/librbd/librbd.cc:3963
#16 0x00007f604e6ffb37 in ?? () from /usr/lib/python2.7/dist-packages/rbd.x86_64-linux-gnu.so
#17 0x00007f604e71c41a in ?? () from /usr/lib/python2.7/dist-packages/rbd.x86_64-linux-gnu.so
#18 0x000055f96bd0e5b4 in ?? ()
#19 0x000055f96c0fa980 in ?? ()

/a/sage-2019-02-14_22:46:36-upgrade:luminous-x-master-distro-basic-smithi/3591180

seems to trigger every time: http://pulpito.ceph.com/sage-2019-02-14_22:46:36-upgrade:luminous-x-master-distro-basic-smithi/

...
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:    self.test(*self.arg)
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 276, in test_list
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:    eq([image_name], RBD().list(ioctx))
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:AssertionError: ['image349'] != [u'image32', u'image349', u'image35', u'image37']
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:======================================================================
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:FAIL: test_rbd.test_rename
2019-02-15T01:10:16.154 INFO:tasks.workunit.client.0.smithi032.stderr:----------------------------------------------------------------------
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:Traceback (most recent call last):
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:    self.test(*self.arg)
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 283, in test_rename
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:    eq([image_name2], rbd.list(ioctx))
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:AssertionError: ['image351'] != [u'image32', u'image35', u'image351', u'image37']
2019-02-15T01:10:16.155 INFO:tasks.workunit.client.0.smithi032.stderr:
2019-02-15T01:10:16.156 INFO:tasks.workunit.client.0.smithi032.stderr:----------------------------------------------------------------------
2019-02-15T01:10:16.157 INFO:tasks.workunit.client.0.smithi032.stderr:Ran 101 tests in 2320.626s
2019-02-15T01:10:16.157 INFO:tasks.workunit.client.0.smithi032.stderr:
2019-02-15T01:10:16.157 INFO:tasks.workunit.client.0.smithi032.stderr:FAILED (SKIP=8, errors=3, failures=5)
2019-02-15T01:10:16.204 INFO:tasks.workunit.client.0.smithi032.stderr:Segmentation fault (core dumped)

(during shutdown?)
(gdb) thr app all bt

Thread 5 (Thread 0x7f6020ff9700 (LWP 15945)):
#0  0x00007f605db7bf85 in futex_abstimed_wait_cancelable (private=<optimized out>, abstime=0x7f6020ff8e70, expected=0, futex_word=0x7f60280531f8) at ../sysdeps/unix/sysv/linux/futex-internal.h:205
#1  __pthread_cond_wait_common (abstime=0x7f6020ff8e70, mutex=0x7f601c0ec8d8, cond=0x7f60280531d0) at pthread_cond_wait.c:539
#2  __pthread_cond_timedwait (cond=0x7f60280531d0, mutex=0x7f601c0ec8d8, abstime=0x7f6020ff8e70) at pthread_cond_wait.c:667
#3  0x00007f604e30d2d0 in Cond::WaitInterval<std::chrono::duration<long, std::ratio<1l, 1l> > > (interval=..., mutex=..., this=0x7f60280531c8) at ./src/common/Cond.h:85
#4  ObjectCacher::flusher_entry (this=0x7f6028052fd0) at ./src/osdc/ObjectCacher.cc:1972
#5  0x00007f604e322b8d in ObjectCacher::FlusherThread::entry (this=<optimized out>) at ./src/osdc/ObjectCacher.h:433
#6  0x00007f605db756db in start_thread (arg=0x7f6020ff9700) at pthread_create.c:463
#7  0x00007f605deae88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 4 (Thread 0x7f60217fa700 (LWP 15944)):
#0  0x00007f605db7b9f3 in futex_wait_cancelable (private=<optimized out>, expected=0, futex_word=0x7f6028053290) at ../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x7f6028053240, cond=0x7f6028053268) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x7f6028053268, mutex=0x7f6028053240) at pthread_cond_wait.c:655
#3  0x00007f60510ed620 in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007f6051879525 in Finisher::finisher_thread_entry (this=0x7f6028053238) at ./src/common/Finisher.cc:86
#5  0x00007f605db756db in start_thread (arg=0x7f60217fa700) at pthread_create.c:463
#6  0x00007f605deae88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 3 (Thread 0x7f60237fe700 (LWP 15932)):
#0  0x00007f605db7b9f3 in futex_wait_cancelable (private=<optimized out>, expected=0, futex_word=0x7f6028012eb0) at ../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x7f6028012e60, cond=0x7f6028012e88) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x7f6028012e88, mutex=0x7f6028012e60) at pthread_cond_wait.c:655
#3  0x00007f60510ed620 in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007f6051879525 in Finisher::finisher_thread_entry (this=0x7f6028012e58) at ./src/common/Finisher.cc:86
#5  0x00007f605db756db in start_thread (arg=0x7f60237fe700) at pthread_create.c:463
#6  0x00007f605deae88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7f6022ffd700 (LWP 15933)):
#0  0x00007f605db7bf85 in futex_abstimed_wait_cancelable (private=<optimized out>, abstime=0x7f6022ffce70, expected=0, futex_word=0x7f6028012e18) at ../sysdeps/unix/sysv/linux/futex-internal.h:205
#1  __pthread_cond_wait_common (abstime=0x7f6022ffce70, mutex=0x7f601c154e88, cond=0x7f6028012df0) at pthread_cond_wait.c:539
#2  __pthread_cond_timedwait (cond=0x7f6028012df0, mutex=0x7f601c154e88, abstime=0x7f6022ffce70) at pthread_cond_wait.c:667
#3  0x00007f604e30d2d0 in Cond::WaitInterval<std::chrono::duration<long, std::ratio<1l, 1l> > > (interval=..., mutex=..., this=0x7f6028012de8) at ./src/common/Cond.h:85
#4  ObjectCacher::flusher_entry (this=0x7f6028012bf0) at ./src/osdc/ObjectCacher.cc:1972
#5  0x00007f604e322b8d in ObjectCacher::FlusherThread::entry (this=<optimized out>) at ./src/osdc/ObjectCacher.h:433
#6  0x00007f605db756db in start_thread (arg=0x7f6022ffd700) at pthread_create.c:463
#7  0x00007f605deae88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 1 (Thread 0x7f605e38e740 (LWP 15575)):
#0  __GI___pthread_mutex_lock (mutex=0x38) at ../nptl/pthread_mutex_lock.c:65
#1  0x00007f6051b8b1f1 in __gthread_mutex_lock (__mutex=0x38) at /usr/include/x86_64-linux-gnu/c++/7/bits/gthr-default.h:748
#2  std::mutex::lock (this=0x38) at /usr/include/c++/7/bits/std_mutex.h:103
#3  std::unique_lock<std::mutex>::lock (this=0x7ffd1ac992c0) at /usr/include/c++/7/bits/std_mutex.h:267
#4  std::unique_lock<std::mutex>::unique_lock (__m=..., this=0x7ffd1ac992c0) at /usr/include/c++/7/bits/std_mutex.h:197
#5  ceph::logging::Log::submit_entry (this=0x0, e=...) at ./src/log/Log.cc:177
#6  0x00007f604e08e4b1 in librbd::Watcher::block_notifies (this=this@entry=0x7f6028019350, on_finish=on_finish@entry=0x55f96d4baca0) at ./src/librbd/Watcher.cc:197
#7  0x00007f604e0363d1 in librbd::ImageWatcher<librbd::ImageCtx>::block_notifies (this=this@entry=0x7f6028019350, on_finish=0x55f96d4baca0) at ./src/librbd/ImageWatcher.cc:104
#8  0x00007f604e11cde8 in librbd::image::CloseRequest<librbd::ImageCtx>::send_block_image_watcher (this=this@entry=0x55f96d081990) at ./src/librbd/image/CloseRequest.cc:51
#9  0x00007f604e11d035 in librbd::image::CloseRequest<librbd::ImageCtx>::send (this=this@entry=0x55f96d081990) at ./src/librbd/image/CloseRequest.cc:37
#10 0x00007f604e025faf in librbd::ImageState<librbd::ImageCtx>::send_close_unlock (this=0x55f96d4293b0) at ./src/librbd/ImageState.cc:618
#11 0x00007f604e0268d5 in librbd::ImageState<librbd::ImageCtx>::execute_next_action_unlock (this=this@entry=0x55f96d4293b0) at ./src/librbd/ImageState.cc:520
#12 0x00007f604e026999 in librbd::ImageState<librbd::ImageCtx>::execute_action_unlock (this=this@entry=0x55f96d4293b0, action=..., on_finish=on_finish@entry=0x7ffd1ac99620) at ./src/librbd/ImageState.cc:542
#13 0x00007f604e027551 in librbd::ImageState<librbd::ImageCtx>::close (this=this@entry=0x55f96d4293b0, on_finish=on_finish@entry=0x7ffd1ac99620) at ./src/librbd/ImageState.cc:293
#14 0x00007f604e027762 in librbd::ImageState<librbd::ImageCtx>::close (this=0x55f96d4293b0) at ./src/librbd/ImageState.cc:276
#15 0x00007f604dfe2c33 in rbd_close (image=0x55f96d49dff0) at ./src/librbd/librbd.cc:3963
#16 0x00007f604e6ffb37 in ?? () from /usr/lib/python2.7/dist-packages/rbd.x86_64-linux-gnu.so
#17 0x00007f604e71c41a in ?? () from /usr/lib/python2.7/dist-packages/rbd.x86_64-linux-gnu.so
#18 0x000055f96bd0e5b4 in ?? ()
#19 0x000055f96c0fa980 in ?? ()
#20 0x0000000000000003 in ?? ()
#21 0x000055f96bccb2d0 in ?? ()
#22 0x00007f605b0307a0 in ?? ()
#23 0x000055f96cc7f2f0 in ?? ()
#24 0x00007f605b0340f0 in ?? ()
#25 0x00007f605b033e88 in ?? ()
#26 0x0000000000000003 in ?? ()
#27 0x000055f96cc7f2f0 in ?? ()
#28 0x000055f96bd628f0 in ?? ()
#29 0xfffffffffffffffe in ?? ()
#30 0x000055f96bcf148a in ?? ()
#31 0x000055f96d18b3e0 in ?? ()
#32 0x000055f96bcc20bb in ?? ()
#33 0x000055f96bd0e0b0 in ?? ()
#34 0x000055f96d0ade20 in ?? ()
#35 0x0000000000000000 in ?? ()
Actions #1

Updated by Sage Weil about 5 years ago

This is on role client.0, post-upgrade to master. The workunit (i.e., the bash) is luminous, fwiw

  - workunit:
      branch: luminous
      clients:
        client.0:
        - rbd/test_librbd_python.sh

Actions #2

Updated by Mykola Golub about 5 years ago

  • Subject changed from luminous->nautilus: qa/workunits/rbd/test_librbd_python.sh segv to luminous->nautilus: test_rbd.TestClone.test_unprotect_with_children: InvalidArgument: [errno 22] error unprotecting snapshot

test_rbd.test_rename error and the segfault are just consequences of an earlier test failure, due to imperfect test cleanup in the case of error. The real issue is:

2019-02-15T00:41:30.470 INFO:tasks.workunit.client.0.smithi184.stderr:======================================================================
2019-02-15T00:41:30.470 INFO:tasks.workunit.client.0.smithi184.stderr:ERROR: test_rbd.TestClone.test_unprotect_with_children
2019-02-15T00:41:30.470 INFO:tasks.workunit.client.0.smithi184.stderr:----------------------------------------------------------------------
2019-02-15T00:41:30.470 INFO:tasks.workunit.client.0.smithi184.stderr:Traceback (most recent call last):
2019-02-15T00:41:30.470 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/case.py", line 384, in tearDown
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:    try_run(self.inst, ('teardown', 'tearDown'))
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:    return func()
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 891, in tearDown
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:    self.image.unprotect_snap('snap1')
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:  File "rbd.pyx", line 3379, in rbd.Image.unprotect_snap (/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_6
4/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/14.0.1-3734-gb1b7174/rpm/el7/BUILD/ceph-14.0.1-3734-gb1b7174/build/src/pybind/rbd/pyrex/rbd.c:30541)
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:InvalidArgument: [errno 22] error unprotecting snapshot image32@snap1
2019-02-15T00:41:30.471 INFO:tasks.workunit.client.0.smithi184.stderr:
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:======================================================================
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:ERROR: test_rbd.TestClone.test_unprotected
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:----------------------------------------------------------------------
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:Traceback (most recent call last):
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/case.py", line 384, in tearDown
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:    try_run(self.inst, ('teardown', 'tearDown'))
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/util.py", line 471, in try_run
2019-02-15T00:41:30.472 INFO:tasks.workunit.client.0.smithi184.stderr:    return func()
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 894, in tearDown
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:    remove_image()
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 81, in remove_image
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:    RBD().remove(ioctx, image_name)
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:  File "rbd.pyx", line 1203, in rbd.RBD.remove (/home/jenkins-build/build/workspace/ceph-dev-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/14.0.1-3734-gb1b7174/rpm/el7/BUILD/ceph-14.0.1-3734-gb1b7174/build/src/pybind/rbd/pyrex/rbd.c:7483)
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:ImageHasSnapshots: [errno 39] error removing image
2019-02-15T00:41:30.473 INFO:tasks.workunit.client.0.smithi184.stderr:

Actions #3

Updated by Mykola Golub about 5 years ago

  • Subject changed from luminous->nautilus: test_rbd.TestClone.test_unprotect_with_children: InvalidArgument: [errno 22] error unprotecting snapshot to luminous->nautilus: test_rbd.TestClone.test_unprotect_with_children: AssertionError: ImageBusy not raised

Or actually the errors above were also after real failure in the tests tear down, and the failure is:

2019-02-15T00:41:30.475 INFO:tasks.workunit.client.0.smithi184.stderr:======================================================================
2019-02-15T00:41:30.475 INFO:tasks.workunit.client.0.smithi184.stderr:FAIL: test_rbd.TestClone.test_unprotect_with_children
2019-02-15T00:41:30.475 INFO:tasks.workunit.client.0.smithi184.stderr:----------------------------------------------------------------------
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:Traceback (most recent call last):
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:    self.test(*self.arg)
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 972, in test_unprotect_with_children
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:    assert_raises(ImageBusy, self.image.unprotect_snap, 'snap1')
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:AssertionError: ImageBusy not raised
2019-02-15T00:41:30.476 INFO:tasks.workunit.client.0.smithi184.stderr:
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:======================================================================
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:FAIL: test_rbd.TestClone.test_unprotected
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:----------------------------------------------------------------------
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:Traceback (most recent call last):
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:    self.test(*self.arg)
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:  File "/home/ubuntu/cephtest/clone.client.0/src/test/pybind/test_rbd.py", line 938, in test_unprotected
2019-02-15T00:41:30.477 INFO:tasks.workunit.client.0.smithi184.stderr:    'snap2', ioctx, clone_name2, features)
2019-02-15T00:41:30.478 INFO:tasks.workunit.client.0.smithi184.stderr:AssertionError: InvalidArgument not raised
2019-02-15T00:41:30.478 INFO:tasks.workunit.client.0.smithi184.stderr:

Actions #4

Updated by Mykola Golub about 5 years ago

The problem is that after upgrade to the master the librbd client starts to support clone v2 format, and with the default "rbd_default_clone_format", which is "auto", the "test_unprotect_with_children" creates the clone of v2 format, which allows to unprotect and remove a busy snap. In the master [1] this test explicitly sets "rbd_default_clone_format" to "1".

I am not sure it would be correct to backport this test modification to the luminous branch. Probably, set "rbd_default_clone_format" to "1" in ceph.conf or in CEPH_ARGS env for these upgrade tests?

[1] https://github.com/ceph/ceph/blob/cc1a7ea9722ef76b1b4d43eb4708b76ef846c61d/src/test/pybind/test_rbd.py#L1251

Actions #5

Updated by Mykola Golub about 5 years ago

  • Status changed from 12 to In Progress
  • Assignee set to Mykola Golub
Actions #6

Updated by Mykola Golub about 5 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 26485
Actions #7

Updated by Sage Weil about 5 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF