Project

General

Profile

Actions
Copy link

Cleanup #3583

closed

Convert tabs to spaces

Added by caleb miles over 11 years ago. Updated over 11 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:

Description

It was recently suggested that there are places in the client where we use spaces for indentation instead of tabs as per 

http://www.kernel.org/doc/Documentation/CodingStyle

we should follow kernel coding style.

Actions
Copy link
 #1

Updated by Yehuda Sadeh over 11 years ago

I think we should avoid doing changes that make it hard to see the history. Specifically, swiping spaces to tabs conversions. Maybe first evaluate what the required changes are and then decide what we can actually achieve?
Maybe make it a habit ro run checkpatch on any kernel related changes before sending a pull request would better serve the purpose?

Actions
Copy link
 #2

Updated by Sage Weil over 11 years ago

  • Status changed from New to Rejected

yeah this is a no-no for kernel. if you touch a line of code, fix whitespace, otherwise let it be.

Actions
Copy link

Also available in: Atom PDF