Project

General

Profile

Actions

Bug #3581

closed

init script errors after upgrade from 0.48 to 0.55

Added by salvatore giudice over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I upgraded from o.48 (latest stable) to 0.55. Ceph seems to start fine using:

/etc/init.d/ceph -a restart

However, there are two errors reported on lines 280 and 303:

root@node01:~# /etc/init.d/ceph -a restart
=== mon.node01 === 
=== mon.node01 === 
Stopping Ceph mon.node01 on node01...done
=== mon.node01 === 
Starting Ceph mon.node01 on node01...
starting mon.node01 rank 0 at 10.128.12.6:6789/0 mon_data /var/lib/ceph/mon/mon.node01 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mon.node02 === 
=== mon.node02 === 
Stopping Ceph mon.node02 on node02...kill 27982...done
=== mon.node02 === 
Starting Ceph mon.node02 on node02...
starting mon.node02 rank 1 at 10.128.12.7:6789/0 mon_data /var/lib/ceph/mon/mon.node02 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mon.node03 === 
=== mon.node03 === 
Stopping Ceph mon.node03 on node03...kill 4200...done
=== mon.node03 === 
Starting Ceph mon.node03 on node03...
starting mon.node03 rank 2 at 10.128.12.8:6789/0 mon_data /var/lib/ceph/mon/mon.node03 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mon.node04 === 
=== mon.node04 === 
Stopping Ceph mon.node04 on node04...kill 32293...done
=== mon.node04 === 
Starting Ceph mon.node04 on node04...
starting mon.node04 rank 3 at 10.128.12.9:6789/0 mon_data /var/lib/ceph/mon/mon.node04 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mon.node05 === 
=== mon.node05 === 
Stopping Ceph mon.node05 on node05...kill 17978...done
=== mon.node05 === 
Starting Ceph mon.node05 on node05...
starting mon.node05 rank 4 at 10.128.12.10:6789/0 mon_data /var/lib/ceph/mon/mon.node05 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mon.node06 === 
=== mon.node06 === 
Stopping Ceph mon.node06 on node06...kill 26768...done
=== mon.node06 === 
Starting Ceph mon.node06 on node06...
starting mon.node06 rank 5 at 10.128.12.11:6789/0 mon_data /var/lib/ceph/mon/mon.node06 fsid 21234148-960c-4664-93ab-918144b7da3e
=== mds.node01 === 
=== mds.node01 === 
Stopping Ceph mds.node01 on node01...kill 30480...done
=== mds.node01 === 
Starting Ceph mds.node01 on node01...
starting mds.node01 at :/0
=== mds.node02 === 
=== mds.node02 === 
Stopping Ceph mds.node02 on node02...kill 28453...done
=== mds.node02 === 
Starting Ceph mds.node02 on node02...
starting mds.node02 at :/0
=== mds.node03 === 
=== mds.node03 === 
Stopping Ceph mds.node03 on node03...kill 4557...done
=== mds.node03 === 
Starting Ceph mds.node03 on node03...
starting mds.node03 at :/0
=== mds.node04 === 
=== mds.node04 === 
Stopping Ceph mds.node04 on node04...kill 32650...done
=== mds.node04 === 
Starting Ceph mds.node04 on node04...
starting mds.node04 at :/0
=== mds.node05 === 
=== mds.node05 === 
Stopping Ceph mds.node05 on node05...kill 18340...done
=== mds.node05 === 
Starting Ceph mds.node05 on node05...
starting mds.node05 at :/0
=== mds.node06 === 
=== mds.node06 === 
Stopping Ceph mds.node06 on node06...kill 27127...done
=== mds.node06 === 
Starting Ceph mds.node06 on node06...
starting mds.node06 at :/0
=== osd.0 === 
=== osd.0 === 
Stopping Ceph osd.0 on node01...kill 30870...done
=== osd.0 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node01:/var/lib/ceph/osd/osd.0
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.0 on node01...
starting osd.0 at :/0 osd_data /var/lib/ceph/osd/osd.0 /var/lib/ceph/osd/osd.0/journal
=== osd.1 === 
=== osd.1 === 
Stopping Ceph osd.1 on node02...kill 29137...done
=== osd.1 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node02:/var/lib/ceph/osd/osd.1
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.1 on node02...
starting osd.1 at :/0 osd_data /var/lib/ceph/osd/osd.1 /var/lib/ceph/osd/osd.1/journal
=== osd.2 === 
=== osd.2 === 
Stopping Ceph osd.2 on node03...kill 5135...done
=== osd.2 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node03:/var/lib/ceph/osd/osd.2
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.2 on node03...
starting osd.2 at :/0 osd_data /var/lib/ceph/osd/osd.2 /var/lib/ceph/osd/osd.2/journal
=== osd.3 === 
=== osd.3 === 
Stopping Ceph osd.3 on node04...kill 757...done
=== osd.3 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node04:/var/lib/ceph/osd/osd.3
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.3 on node04...
starting osd.3 at :/0 osd_data /var/lib/ceph/osd/osd.3 /var/lib/ceph/osd/osd.3/journal
=== osd.4 === 
=== osd.4 === 
Stopping Ceph osd.4 on node05...kill 18922...done
=== osd.4 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node05:/var/lib/ceph/osd/osd.4
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.4 on node05...
starting osd.4 at :/0 osd_data /var/lib/ceph/osd/osd.4 /var/lib/ceph/osd/osd.4/journal
=== osd.5 === 
=== osd.5 === 
Stopping Ceph osd.5 on node06...kill 27695...done
=== osd.5 === 
/etc/init.d/ceph: 280: /etc/init.d/ceph: fs_type: not found
/etc/init.d/ceph: 303: [: unexpected operator
Mounting on node06:/var/lib/ceph/osd/osd.5
Usage: modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]
modprobe -r [-n] [-i] [-v] <modulename> ...
modprobe -l -t <dirname> [ -a <modulename> ...]
Starting Ceph osd.5 on node06...
starting osd.5 at :/0 osd_data /var/lib/ceph/osd/osd.5 /var/lib/ceph/osd/osd.5/journal
root@node01:~# /etc/init.d/ceph -a status
=== mon.node01 === 
mon.node01: running {"version":"0.55"}
=== mon.node02 === 
mon.node02: running {"version":"0.55"}
=== mon.node03 === 
mon.node03: running {"version":"0.55"}
=== mon.node04 === 
mon.node04: running {"version":"0.55"}
=== mon.node05 === 
mon.node05: running {"version":"0.55"}
=== mon.node06 === 
mon.node06: running {"version":"0.55"}
=== mds.node01 === 
mds.node01: running {"version":"0.55"}
=== mds.node02 === 
mds.node02: running {"version":"0.55"}
=== mds.node03 === 
mds.node03: running {"version":"0.55"}
=== mds.node04 === 
mds.node04: running {"version":"0.55"}
=== mds.node05 === 
mds.node05: running {"version":"0.55"}
=== mds.node06 === 
mds.node06: running {"version":"0.55"}
=== osd.0 === 
osd.0: running {"version":"0.55"}
=== osd.1 === 
osd.1: running {"version":"0.55"}
=== osd.2 === 
osd.2: running {"version":"0.55"}
=== osd.3 === 
osd.3: running {"version":"0.55"}
=== osd.4 === 
osd.4: running {"version":"0.55"}
=== osd.5 === 
osd.5: running {"version":"0.55"}
Actions #1

Updated by Dan Mick over 11 years ago

  • Status changed from New to Resolved
Actions #2

Updated by Alan V over 11 years ago

Hi,

not all. After apply path I see error "/etc/init.d/ceph: 303: [: btrfs: unexpected operator"

root@bacula-s2:~# /etc/init.d/ceph restart osd === osd.10 === === osd.10 ===
Stopping Ceph osd.10 on bacula-s2...done === osd.10 ===
/etc/init.d/ceph: 303: [: btrfs: unexpected operator
Mounting btrfs on bacula-s2:/srv/slow_fs/osd.10
Starting Ceph osd.10 on bacula-s2...
starting osd.10 at :/0 osd_data /srv/slow_fs/osd.10 /srv/fast_fs/journal/osd.10.journal === osd.11 === === osd.11 ===
Stopping Ceph osd.11 on bacula-s2...done === osd.11 ===
/etc/init.d/ceph: 303: [: btrfs: unexpected operator
Mounting btrfs on bacula-s2:/srv/slow_fs/osd.11
Starting Ceph osd.11 on bacula-s2...
starting osd.11 at :/0 osd_data /srv/slow_fs/osd.11 /srv/fast_fs/journal/osd.11.journal === osd.9 === === osd.9 ===
Stopping Ceph osd.9 on bacula-s2...done === osd.9 ===
/etc/init.d/ceph: 303: [: btrfs: unexpected operator
Mounting btrfs on bacula-s2:/srv/slow_fs/osd.9
Starting Ceph osd.9 on bacula-s2...
starting osd.9 at :/0 osd_data /srv/slow_fs/osd.9 /srv/fast_fs/journal/osd.9.journal
root@bacula-s2:~#

fix

/etc/init.d/ceph: 303
----------
- if [ "$fs_type" "btrfs" ]; then
+ if [ "$fs_type""btrfs" ]; then
----------

Actions #3

Updated by Sage Weil over 11 years ago

Fixed (in next and testing branches), thanks!

Actions #4

Updated by Dan Mick over 11 years ago

  • Status changed from Resolved to 12

I was mistaken about the commit above; that fixes the issue for mkcephfs, but not for init-ceph.in. That bug still exists, although much less severe, because you have to
have specified 'devs' for the osd config.

Still, though, this bug still exists, so reopening.

Actions #5

Updated by Dan Mick over 11 years ago

I think this still needs

--- a/src/init-ceph.in
+++ b/src/init-ceph.in
@@ -277,7 +277,7 @@ for name in $what; do
                    # try to fallback to to old keys
                    get_conf tmp_devs "" "btrfs devs" 
                    if [ -n "$tmp_devs" ]; then
-                       fs_type = "btrfs" 
+                       fs_type="btrfs" 
                    else
                        echo No filesystem type defined!
                        exit 0

Actions #6

Updated by Dan Mick over 11 years ago

  • Status changed from 12 to Resolved
Actions

Also available in: Atom PDF