Project

General

Profile

Actions

Bug #32731

closed

fsck: cid is improperly matched to oid

Added by Igor Fedotov over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
mimic,luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

It looks like the approach to match cid to oid in BlueStore::_fsck isn't valid. It's mainly based on BlueStore::Collection::contains(contains(const ghobject_t& oid) call.
Currently this issue is hidden and seems to have no negative impact but I faced it while debugging PR#19454 - resulted collection and object had different pool id.
I attached short diff and log showing the problem.
Step to reproduce - run new vstart cluster, make a pool and put 128 MB object via "rados put". Restart the cluster - fsck logging (if patched with the attached code) will show the mismatch.


Files

more_log.diff (564 Bytes) more_log.diff patch to extend logging Igor Fedotov, 08/28/2018 11:48 AM
log (13.5 KB) log log snippet for the patched bluestore Igor Fedotov, 08/28/2018 11:48 AM

Related issues 2 (0 open2 closed)

Copied to bluestore - Backport #36145: luminous: fsck: cid is improperly matched to oidResolvedNathan CutlerActions
Copied to bluestore - Backport #36146: mimic: fsck: cid is improperly matched to oidResolvedPrashant DActions
Actions

Also available in: Atom PDF