Project

General

Profile

Actions

Bug #24431

closed

build rpm package error

Added by YongSheng Zhang almost 6 years ago. Updated over 5 years ago.

Status:
Can't reproduce
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph version :ceph-13.1.0
arc:aarch64
error reproduce: run ./make-dist
error output: ===========================
  • Install prebuilt node (8.10.0) .Traceback (most recent call last):
    File "/tmp/tmp.t8sJ5GVNNn/bin/nodeenv", line 11, in <module>
    sys.exit(main())
    File "/tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py", line 1071, in main
    create_environment(env_dir, opt)
    File "/tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py", line 900, in create_environment
    install_node(env_dir, src_dir, opt)
    File "/tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py", line 692, in install_node
    download_node_src(node_url, src_dir, opt, prefix)
    File "/tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py", line 542, in download_node_src
    dl_contents = io.BytesIO(urlopen(node_url).read())
    File "/tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py", line 564, in urlopen
    return urllib2.urlopen(req)
    File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
    File "/usr/lib64/python2.7/urllib2.py", line 437, in open
    response = meth(req, response)
    File "/usr/lib64/python2.7/urllib2.py", line 550, in http_response
    'http', request, response, code, msg, hdrs)
    File "/usr/lib64/python2.7/urllib2.py", line 475, in error
    return self._call_chain(*args)
    File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
    File "/usr/lib64/python2.7/urllib2.py", line 558, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
    urllib2.HTTPError: HTTP Error 404: Not Found ===================================

root cause: nodeenv request url error, the log output url is "https://nodejs.org/dist/v8.10.0/node-v8.10.0-linux-armv64.tar.gz", but
correct url should be "https://nodejs.org/dist/v8.10.0/node-v8.10.0-linux-arm64.tar.gz"

solution:
the file /tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py code diff
508c508
< 'aarch64': 'armv64',
---

'aarch64': 'arm64',

please review

Actions #1

Updated by YongSheng Zhang almost 6 years ago

the file /tmp/tmp.t8sJ5GVNNn/lib/python2.7/site-packages/nodeenv.py code diff
508c508
< 'aarch64': 'armv64',
---

'aarch64': 'arm64',

Actions #2

Updated by YongSheng Zhang almost 6 years ago

508c508
< 'aarch64': 'armv64',
---
> 'aarch64': 'arm64',

Actions #3

Updated by Nathan Cutler almost 6 years ago

  • Project changed from Ceph to mgr
  • Assignee set to Ricardo Dias

Ricardo, could you take a look at this?

Actions #4

Updated by Tiago Melo almost 6 years ago

  • Assignee changed from Ricardo Dias to Tiago Melo

Hi,
It seems this problem is already fixed on the latest master of nodeenv [1].

I have ask the developer when or if he plans to release a new version with this fix.
Depending on the answer I will create a PR to fix the problem on ceph.

In the meanwhile could you try to apply this change to 'make-dist', it will install nodeenv with the latest git code.
And just to be safe, better to remove 'ceph/build/src/pybind/mgr/dashboard/node-env' directory.

diff --git a/make-dist b/make-dist
index eb9aa7b0f2..7accd30262 100755
--- a/make-dist
+++ b/make-dist
@@ -79,7 +79,7 @@ build_dashboard_frontend() {
   CURR_DIR=`pwd`
   TEMP_DIR=`mktemp -d`
   $CURR_DIR/src/tools/setup-virtualenv.sh --python=$(_python_autoselect) $TEMP_DIR
-  $TEMP_DIR/bin/pip install nodeenv
+  $TEMP_DIR/bin/pip install -e git+https://github.com/ekalinin/nodeenv.git#egg=nodeenv
   $TEMP_DIR/bin/nodeenv -p -n 8.10.0
   cd src/pybind/mgr/dashboard/frontend
   . $TEMP_DIR/bin/activate

[1] https://github.com/ekalinin/nodeenv/commit/957df26f10738b9fcbac247d1b013875e101858c
[2] https://github.com/ekalinin/nodeenv/issues/217

Actions #5

Updated by Tiago Melo almost 6 years ago

  • Status changed from New to Need More Info

version 1.3.1 [1] of nodeenv has been release and the problem should be fixed now, without modifying our code.
Could you verify that the issue has been fixed?
Thanks

[1] https://github.com/ekalinin/nodeenv/releases/tag/1.3.1

Actions #6

Updated by Lenz Grimmer over 5 years ago

  • Status changed from Need More Info to Can't reproduce

No more feedback was provided, assuming this is fixed. Please re-open this issue if it persists.

Actions

Also available in: Atom PDF