Actions
Bug #23707
closedUnboundLocalError if command doesn't validate
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The error case in validate_command() where the command is found but the
command itself is somehow invalid raises an UnboundLocalError, because it
tries to refer to a variable named 'e', but it should be 'ex'. For example:
- ceph balancer mode
Traceback (most recent call last):
File "/usr/bin/ceph", line 1178, in <module>
retval = main()
File "/usr/bin/ceph", line 1109, in main
verbose)
File "/usr/bin/ceph", line 535, in new_style_command
valid_dict = validate_command(sigdict, cmdargs, verbose)
File "/usr/lib/python3.6/site-packages/ceph_argparse.py", line 1090, in validate_command
print("Invalid command:", e, file=sys.stderr)
UnboundLocalError: local variable 'e' referenced before assignment
Updated by Kefu Chai about 6 years ago
- Copied to Backport #23708: luminous: UnboundLocalError if command doesn't validate added
Updated by Kefu Chai about 6 years ago
- Status changed from Pending Backport to Resolved
Actions