Ceph » rgw

Taking a look at the request that ceph sends to elastic we see this:

failed to execute bulk item (index) BulkShardRequest [[brontodms]⁴] containing [index {[brontodms][object][ee560b67-c330-4fd0-af50-aefff93735d2.4163.1:newone:null], source[{"bucket":"acmedms","name":"newone","instance":"null","versioned_epoch":0,"owner":{"id":"acme","display_name":"Acme Admin"},"permissions":["acme"],"meta":{"size":8,"mtime":"2018-03-13T14:53:38.447Z","content_type":"text/plain","crypt.keyid":"cd4d0092-41dd-4144-b2ce-4be41c0b558","crypt.keysel":"\u0004\u0002v%�{l�QN�Zo��\u0002���İ\u000bK`J'��T�v","crypt.mode":"SSE-KM","etag":"eb1a3227cdc3fedbaec2fe38bf6c044a","tail_tag":"ee560b67-c330-4fd0-af50-aefff93735d2.54110.136607","x-amz-content-sha256":"12a61f4e173fb3a11c05d6471f74728f76231b4a5fcd9667cef3af87a3ae4dc2","x-amz-date":"20180313T145337Z","x-amz-server-side-encryption":"aws:kms","x-amz-server-side-encryption-aws-kms-key-id":"cd4d0092-41dd-4144-b2ce-4be41c0b5582","x-amz-storage-class":"STANDARD","custom-string":[{"name":"s3cmd-attrs","value":"uid:1000/gname:amardeep/uname:amardeep/gid:1000/mode:33204/mtime:1518453135/atime:1520936897/md5:eb1a3227cdc3fedbaec2fe38bf6c044a/ctime:1518453135"}]}}]}]

Which shows incorrect encoding here:
"crypt.keysel":"\u0004\u0002v%�{l�QN�Zo��\u0002���İ\u000bK`J'��T�v"

Caused by:
https://github.com/ceph/ceph/blob/master/src/rgw/rgw_crypt.cc#L1120

Working on a fix for this.

Here's a patch for this, it's been sitting with us for a while!

---
 src/rgw/rgw_crypt.cc | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/rgw/rgw_crypt.cc b/src/rgw/rgw_crypt.cc
index 81a84ad698..db3677d603 100644
--- a/src/rgw/rgw_crypt.cc
+++ b/src/rgw/rgw_crypt.cc
@@ -826,10 +826,13 @@ int RGWPutObj_BlockEncrypt::throttle_data(void *handle,

 std::string create_random_key_selector(CephContext * const cct) {
   char random[AES_256_KEYSIZE];
-  if (get_random_bytes(&random[0], sizeof(random)) != 0) {
-    ldout(cct, 0) << "ERROR: cannot get_random_bytes. " << dendl;
-    for (char& v:random) v=rand();
-  }
+  char* first = begin(random);
+  char* last = end(random);
+  do {
+    get_random_bytes(first, last - first);
+    first = find_if(first, last,
+                    [](char c) { return !isprint(c) || c == '"' || c == '\\'; });
+  } while (first != last);
   return std::string(random, sizeof(random));
 }

-- 

---
 src/rgw/rgw_crypt.cc | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/rgw/rgw_crypt.cc b/src/rgw/rgw_crypt.cc
index 81a84ad698..db3677d603 100644
--- a/src/rgw/rgw_crypt.cc
+++ b/src/rgw/rgw_crypt.cc
@@ -826,10 +826,13 @@ int RGWPutObj_BlockEncrypt::throttle_data(void *handle,

 std::string create_random_key_selector(CephContext * const cct) {
   char random[AES_256_KEYSIZE];
-  if (get_random_bytes(&random[0], sizeof(random)) != 0) {
-    ldout(cct, 0) << "ERROR: cannot get_random_bytes. " << dendl;
-    for (char& v:random) v=rand();
-  }
+  char* first = begin(random);
+  char* last = end(random);
+  do {
+    get_random_bytes(first, last - first);
+    first = find_if(first, last,
+                    [](char c) { return !isprint(c) || c == '"' || c == '\\'; });
+  } while (first != last);
   return std::string(random, sizeof(random));
 }

--