Project

General

Profile

Bug #22988

mount check needs to resolve realpaths

Added by Alfredo Deza about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Immediate
Assignee:
Target version:
Start date:
02/13/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

The default behavior of checking for realpaths in the system utilities got changed to avoiding them:

commit 469d01dc1aee8d6528944ef0acec58df868a9da7
Author: Alfredo Deza <adeza@redhat.com>
Date:   Tue Jan 30 09:22:19 2018 -0500

    ceph-volume util.system do not 'translate' using realpath

    Using realpath always means that device mapper paths, like for dmcrypt
    or LVM will get mangled and will return something like `/dev/dm-1` which
    is not useful for anything in ceph-volume

This is causing certain paths to be reported as "unmounted" so the system will try to mount regardless and then fail:

Running command: mount -v /dev/test_group/data-lv2 /var/lib/ceph/osd/ceph-0
 stderr: mount: /dev/mapper/test_group-data--lv2 is already mounted or /var/lib/ceph/osd/ceph-0 busy
       /dev/mapper/test_group-data--lv2 is already mounted on /var/lib/ceph/osd/ceph-0

The fix is to optionally allow resolving paths, in addition to checking the stderr output in case of a non-zero exit status so that an "already mounted"
error can be ignored.

History

#1 Updated by Alfredo Deza about 1 year ago

  • Status changed from In Progress to Need Review

#2 Updated by Alfredo Deza about 1 year ago

  • Status changed from Need Review to Resolved

merged commit 5f7c250 into master

Also available in: Atom PDF