Project

General

Profile

Bug #22124

rgw: user stats increased after bucket reshard

Added by Aleksei Gutikov about 1 year ago. Updated 10 months ago.

Status:
Resolved
Priority:
Urgent
Target version:
-
Start date:
11/14/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
rgw
Pull request ID:

Description

after calling

./bin/radosgw-admin bucket reshard --num-shards=10 --bucket=xxx

User stats increases like after adding another same bucket with data.


Related issues

Copied to rgw - Backport #22434: luminous: rgw: user stats increased after bucket reshard Resolved
Copied to rgw - Backport #22987: jewel: rgw: user stats increased after bucket reshard Resolved

History

#2 Updated by Sage Weil about 1 year ago

  • Status changed from New to Need Review
  • Priority changed from Normal to Urgent

#3 Updated by Aleksei Gutikov about 1 year ago

Aleksei Gutikov wrote:

https://github.com/ceph/ceph/pull/18922

Sorry, this is not the fix, mixed up with http://tracker.ceph.com/issues/22122

#4 Updated by Casey Bodley about 1 year ago

  • Status changed from Need Review to New

#5 Updated by Orit Wasserman about 1 year ago

  • Assignee set to Orit Wasserman

#6 Updated by Orit Wasserman about 1 year ago

  • Backport set to luminous

#7 Updated by Yehuda Sadeh about 1 year ago

We probably need to remove the stats entry for the old bucket instance from the user stats.

#8 Updated by Orit Wasserman about 1 year ago

need also to reset user stats

#10 Updated by Orit Wasserman about 1 year ago

  • Status changed from New to Need Review

#11 Updated by Orit Wasserman about 1 year ago

  • Status changed from Need Review to Need Test

#12 Updated by Yehuda Sadeh about 1 year ago

  • Status changed from Need Test to Pending Backport

#13 Updated by Nathan Cutler about 1 year ago

  • Copied to Backport #22434: luminous: rgw: user stats increased after bucket reshard added

#14 Updated by Zongyou Yao about 1 year ago

@Orit Wasserman, the pr https://github.com/ceph/ceph/pull/19253 has introduced a new bug, after this pr, execute the command `./bin/radosgw-admin bucket reshard --num-shards=10 --bucket=xxx` and the bucket xxx is missing from get service list,here is a test:

  1. s3cmd mb s3://testbucket
    Bucket 's3://testbucket/' created
  2. s3cmd ls
    2018-01-11 06:48 s3://testbucket
  3. ./bin/radosgw-admin bucket reshard --bucket=testbucket --num-shards=10
    2018-01-11 14:49:00.964 7fedf81ab3c0 -1 WARNING: all dangerous and experimental features are enabled.
    2018-01-11 14:49:00.964 7fedf81ab3c0 -1 WARNING: all dangerous and experimental features are enabled.
    2018-01-11 14:49:00.984 7fedf81ab3c0 -1 WARNING: all dangerous and experimental features are enabled.
    2018-01-11 14:49:01.424 7fedf81ab3c0 0 WARNING: detected a version of libcurl which contains a bug in curl_multi_wait(). enabling a workaround that may degrade performance slightly.
    • NOTICE: operation will not remove old bucket index objects ***
    • these will need to be removed manually ***
      tenant:
      bucket name: testbucket
      old bucket instance id: 071ae4cf-ffb2-4a82-8b7a-ca1ebd5e204f.4153.1
      new bucket instance id: 071ae4cf-ffb2-4a82-8b7a-ca1ebd5e204f.4148.1
      total entries: 0
  4. s3cmd ls #

the testbucket is missing.

And I have tested even before this commit, the user stats not increased after bucket reshard.

Maybe we need to revert the commit.

#15 Updated by Orit Wasserman 12 months ago

I will check it

#16 Updated by Orit Wasserman 12 months ago

@Zongyou Yao thanks for catching this.
I revert the pr and I will try a different fix.

#17 Updated by Orit Wasserman 12 months ago

  • Status changed from Pending Backport to In Progress

#19 Updated by Orit Wasserman 12 months ago

  • Status changed from In Progress to Need Review

#20 Updated by Yuri Weinstein 12 months ago

merged luminous backport: https://github.com/ceph/ceph/pull/20327

#21 Updated by Nathan Cutler 12 months ago

  • Status changed from Need Review to Pending Backport

#22 Updated by Nathan Cutler 12 months ago

  • Status changed from Pending Backport to Resolved

#23 Updated by Nathan Cutler 11 months ago

  • Status changed from Resolved to Pending Backport
  • Backport changed from luminous to luminous jewel

Adding jewel backport

#24 Updated by Nathan Cutler 11 months ago

  • Copied to Backport #22987: jewel: rgw: user stats increased after bucket reshard added

#25 Updated by Nathan Cutler 10 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF