Project

General

Profile

Actions

Cleanup #20811

closed

warning: ‘<<’ in boolean context, did you mean ‘<’ ? [-Wint-in-bool-context]

Added by Amit Kumar over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Category:
OSD
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

  1. pwd
    /root/ceph/build
  2. make -j4
    /root/ceph/src/osd/PGLog.h:29:43: warning: ‘<<’ in boolean context, did you mean ‘<’ ? [-Wint-in-bool-context]
    #define PGLOG_INDEXED_DUPS (1 << 3)
    ~~^~~~
    /root/ceph/src/osd/PGLog.h:29:43: note: in definition of macro ‘PGLOG_INDEXED_DUPS’
    #define PGLOG_INDEXED_DUPS (1 << 3)
Actions #1

Updated by Jesse Williamson over 6 years ago

Hi Amit, my apologies as I hadn't seen you'd taken this (I was slow to do so!), but I have a PR here:
https://github.com/ceph/ceph/pull/19352
I hope this doesn't step on your toes.

Actions #2

Updated by Jos Collin over 6 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Jos Collin over 6 years ago

  • Assignee changed from Amit Kumar to Jesse Williamson
Actions #4

Updated by Kefu Chai over 6 years ago

  • Category changed from build to OSD
  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF