Project

General

Profile

Actions
Copy link

Bug #20770

open

test_pidfile.sh test is failing 2 places

Added by David Zafman almost 7 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I've seen both of these on Jenkins make check runs.

test_pidfile.sh line 55


 run_osd $dir 0 2>&1 | grep "failed to lock pidfile" || return 1

/home/dzafman/ceph/src/test/test_pidfile.sh:55: TEST_pidfile:  run_osd td/pidfile 0
/home/dzafman/ceph/src/test/test_pidfile.sh:55: TEST_pidfile:  grep 'failed to lock pidfile'
/home/dzafman/ceph/src/test/test_pidfile.sh:55: TEST_pidfile:  return 1
/home/dzafman/ceph/src/test/test_pidfile.sh:22: run:  return 1

test_pidfile.sh line 36


    expect_failure $dir "ignore empty --pid-file" ceph-mon \
        -f \
        --log-to-stderr \
        --pid-file= \
        --id $id \
        --mon-data=$data \
        --run-dir=$dir || return 1

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:29: TEST_without_pidfile:  local data=td/pidfile/osd1
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:30: TEST_without_pidfile:  local id=1
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:32: TEST_without_pidfile:  ceph-mon --id 1 --mkfs --mon-data=td/pidfile/osd1 --run-dir=td/pidfile
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:36: TEST_without_pidfile:  expect_failure td/pidfile 'ignore empty --pid-file' ceph-mon -f --log-to-stderr --pid-file= --id 1 --mon-data=td/pidfile/osd1 --run-dir=td/pidfile
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1532: expect_failure:  local dir=td/pidfile
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1533: expect_failure:  shift
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1534: expect_failure:  local 'expected=ignore empty --pid-file'
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1535: expect_failure:  shift
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1536: expect_failure:  local success
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1538: expect_failure:  ceph-mon -f --log-to-stderr --pid-file= --id 1 --mon-data=td/pidfile/osd1 --run-dir=td/pidfile
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1541: expect_failure:  success=false
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1544: expect_failure:  false
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1544: expect_failure:  grep --quiet 'ignore empty --pid-file' td/pidfile/out
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1545: expect_failure:  cat td/pidfile/out
/home/jenkins-build/build/workspace/ceph-pull-requests/qa/standalone/ceph-helpers.sh:1546: expect_failure:  return 1
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:42: TEST_without_pidfile:  return 1
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_pidfile.sh:22: run:  return 1

Related issues 2 (0 open — 2 closed)

Related to RADOS - Bug #20975: test_pidfile.sh is flakyResolved08/10/2017

Actions
Copied to Ceph - Backport #21050: luminous: test_pidfile.sh test is failing 2 placesRejectedNathan CutlerActions
Actions
Copy link
 #1

Updated by David Zafman almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by David Zafman almost 7 years ago

  • Assignee changed from Kefu Chai to David Zafman
Actions
Copy link
 #4

Updated by David Zafman over 6 years ago

This is still failing sometimes in TEST_without_pidfile() even after adding a sleep 1.

Actions
Copy link
 #5

Updated by David Zafman over 6 years ago

  • Status changed from New to 12
Actions
Copy link
 #6

Updated by David Zafman over 6 years ago

  • Status changed from 12 to In Progress
Actions
Copy link
 #7

Updated by David Zafman over 6 years ago

  • Status changed from In Progress to 7
  • Backport set to luminous
Actions
Copy link
 #8

Updated by David Zafman over 6 years ago

  • Status changed from 7 to Fix Under Review
Actions
Copy link
 #9

Updated by David Zafman over 6 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #10

Updated by David Zafman over 6 years ago

To backport all the test-pidfile.sh cherry-pick 4 pull requests using the sha1s in this order:

https://github.com/ceph/ceph/pull/16587 sha1 20fee153cada2ea7659199a009679f978cd8fce1
https://github.com/ceph/ceph/pull/16635 sha1 c76f306ff56e46ee5818689a951987f7cefecb31
https://github.com/ceph/ceph/pull/16977 sha1 ff3de2304497544033837bb8d0c809a9e54a3e6e
https://github.com/ceph/ceph/pull/16987 sha1 16ea9b15717e1f2d49d871e5ec60c37c766a29dc

Actions
Copy link
 #11

Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #21050: luminous: test_pidfile.sh test is failing 2 places added
Actions
Copy link
 #12

Updated by Nathan Cutler over 6 years ago

David Zafman wrote:

To backport all the test-pidfile.sh cherry-pick 4 pull requests using the sha1s in this order:

https://github.com/ceph/ceph/pull/16587 sha1 20fee153cada2ea7659199a009679f978cd8fce1
https://github.com/ceph/ceph/pull/16635 sha1 c76f306ff56e46ee5818689a951987f7cefecb31

These two are already in luminous.

https://github.com/ceph/ceph/pull/16977 sha1 ff3de2304497544033837bb8d0c809a9e54a3e6e
https://github.com/ceph/ceph/pull/16987 sha1 16ea9b15717e1f2d49d871e5ec60c37c766a29dc

I cherry-picked these; see https://github.com/ceph/ceph/pull/17161

Actions
Copy link
 #13

Updated by Nathan Cutler over 6 years ago

  • Has duplicate Bug #20975: test_pidfile.sh is flaky added
Actions
Copy link
 #14

Updated by David Zafman over 6 years ago

Another change is needed too. I've requested that in the pull request.

https://github.com/ceph/ceph/pull/17052 sha1 4d56de3608629571d07b48e9e3219420218c0b99

Actions
Copy link
 #15

Updated by Nathan Cutler over 6 years ago

  • Has duplicate deleted (Bug #20975: test_pidfile.sh is flaky)
Actions
Copy link
 #16

Updated by Nathan Cutler over 6 years ago

  • Related to Bug #20975: test_pidfile.sh is flaky added
Actions
Copy link
 #17

Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved
  • Backport deleted (luminous)

luminous backport rejected because the test continued to fail

Actions
Copy link
 #18

Updated by David Zafman over 6 years ago

  • Status changed from Resolved to 12

This problem still hasn't been solved. The is disabled, so moving back to verified.

Actions
Copy link
 #19

Updated by David Zafman about 5 years ago

  • Project changed from Ceph to RADOS
Actions
Copy link
 #20

Updated by Patrick Donnelly over 4 years ago

  • Status changed from 12 to New
Actions
Copy link

Also available in: Atom PDF