Project

General

Profile

Actions

Bug #19588

closed

Issues with C API image metadata retrieval functions

Added by Mykola Golub about 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
kraken,jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

A couple of issues detected when testing rbd_metadata_list API function:
- the provided parameter `vals_len` is not properly checked;
- the output buffers are expected to be zero pre-filled.


Related issues 2 (0 open2 closed)

Copied to rbd - Backport #19611: kraken: Issues with C API image metadata retrieval functionsResolvedNathan CutlerActions
Copied to rbd - Backport #19612: jewel: Issues with C API image metadata retrieval functionsResolvedNathan CutlerActions
Actions #1

Updated by Mykola Golub about 7 years ago

  • Subject changed from rbd_metadata_list API function does not work properly to Issues with C API image metadata retrieval functions

Also, there is an issue with rbd_metadata_get function: on success it does not set update val_len param (which might be ok), but it also does not copy the final '\0' character to the value buffer. As a result the caller can't tell the value length until it pre-fills the buffer with zeros.

Actions #2

Updated by Mykola Golub about 7 years ago

  • Backport set to kraken,jewel
Actions #3

Updated by Mykola Golub about 7 years ago

  • Status changed from In Progress to Fix Under Review
Actions #4

Updated by Mykola Golub about 7 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #19611: kraken: Issues with C API image metadata retrieval functions added
Actions #6

Updated by Nathan Cutler about 7 years ago

  • Copied to Backport #19612: jewel: Issues with C API image metadata retrieval functions added
Actions #7

Updated by Nathan Cutler almost 7 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF