Project

General

Profile

Bug #18297

ceph cli fails on monitors that don't send 'flags' in command descs

Added by Dan Mick 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
ceph cli
Target version:
-
Start date:
12/16/2016
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

61d63433dfdcc08ecc21ba4f645794da5e01823c added the ability to mark commands with flags to say they are obsolete or deprecated, and avoid showing them in help. The code unconditionally looks for the 'flags' key on the command dict, which will not be present when run against older mons.

Validate presence of the key before checking it.


Related issues

Copied to Backport #18318: jewel: ceph cli fails on monitors that don't send 'flags' in command descs Rejected

History

#1 Updated by Sage Weil 5 months ago

  • Status changed from Need Review to Pending Backport
  • Backport set to jewel

#3 Updated by Dan Mick 5 months ago

  • Priority changed from High to Urgent

#4 Updated by Dan Mick 5 months ago

  • Priority changed from Urgent to High

#5 Updated by Nathan Cutler 5 months ago

  • Copied to Backport #18318: jewel: ceph cli fails on monitors that don't send 'flags' in command descs added

#6 Updated by Nathan Cutler 5 months ago

@Dan: Are you sure this fix is applicable to jewel? The flags appear to have been introduced by https://github.com/ceph/ceph/commit/61d63433

#7 Updated by Dan Mick 5 months ago

No; Sage added that backport note, I haven't checked.

#8 Updated by Nathan Cutler 5 months ago

  • Status changed from Pending Backport to Resolved

#9 Updated by Nathan Cutler 5 months ago

  • Backport deleted (jewel)

Also available in: Atom PDF