Bug #1829
SimpleMessenger tries to shut down threads that aren't running
| Status: | Resolved | Start date: | 12/14/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Greg Farnum | % Done: | 0% | |
| Category: | msgr | Spent time: | - | |
| Target version: | v0.40 | |||
| Source: | Severity: | |||
| Backport: | Reviewed: | |||
| Tags: |
Description
Saw this on benjamin yesterday. Looks like the OSD repeatedly restarted its messengers and was eventually unable to rebind to a new port, so the Accepter was never started. But it still tried to join() with the Accepter thread. Boom crash!
Associated revisions
msgr: unset did_bind in stop().
We use did_bind as a flag on whether or not to stop the Accepter thread
and we should clear it when we do the stopping.
This fixes #1829.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
msgr: unset did_bind in stop().
We use did_bind as a flag on whether or not to stop the Accepter thread
and we should clear it when we do the stopping.
This fixes #1829.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
History
#1 Updated by Greg Farnum over 1 year ago
- Status changed from New to Resolved
Oh, even simpler than I expected. Fixed in 55639dcd87fe985059355afe5fab787e4d139b11 (compile tested).