Project

General

Profile

Feature #18206

osd: osd_scrub_during_recovery only considers primary, not replicas

Added by Sage Weil almost 2 years ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Scrub/Repair
Target version:
-
Start date:
12/09/2016
Due date:
% Done:

0%

Source:
Tags:
Backport:
jewel, luminous
Reviewed:
Affected Versions:
Component(RADOS):
OSD
Pull request ID:

Description

We should also avoid scrubbing if the replica is busy doing recovery. That means the scrub scheduler should decline the reservation, probably, but we need to verify that some timed backoff is in place.


Related issues

Copied to RADOS - Backport #21077: luminous: osd: osd_scrub_during_recovery only considers primary, not replicas Resolved
Copied to RADOS - Backport #21117: jewel: osd: osd_scrub_during_recovery only considers primary, not replicas Resolved

History

#1 Updated by Greg Farnum over 1 year ago

  • Tracker changed from Bug to Feature
  • Project changed from Ceph to RADOS
  • Category set to Scrub/Repair
  • Component(RADOS) OSD added

#2 Updated by David Zafman over 1 year ago

  • Status changed from Verified to In Progress
  • Assignee set to David Zafman

#3 Updated by David Zafman over 1 year ago

  • Backport set to jewel, luminous

#4 Updated by Kefu Chai over 1 year ago

david, i just read your inquiry over IRC. what would you want me to review for this ticket? do we have a PR for it already?

#5 Updated by David Zafman over 1 year ago

  • Status changed from In Progress to Need Review

#7 Updated by Kefu Chai about 1 year ago

  • Status changed from Need Review to Pending Backport

#8 Updated by Abhishek Lekshmanan about 1 year ago

  • Copied to Backport #21077: luminous: osd: osd_scrub_during_recovery only considers primary, not replicas added

#9 Updated by Vikhyat Umrao about 1 year ago

  • Backport changed from jewel, luminous to jewel

#10 Updated by Nathan Cutler about 1 year ago

Verified that both commits from https://github.com/ceph/ceph/pull/17039 were cherry-picked to luminous.

#11 Updated by Vikhyat Umrao about 1 year ago

Thanks Nathan. I think some issue and it did not create a tracker for jewel backport so I removed luminous so it can create for jewel.

#12 Updated by Nathan Cutler about 1 year ago

  • Backport changed from jewel to jewel, luminous

@Vikhyat, I think Abhi just created the luminous backport tracker manually. The jewel one will be created automagically when I next run the script.

#13 Updated by Nathan Cutler about 1 year ago

  • Copied to Backport #21117: jewel: osd: osd_scrub_during_recovery only considers primary, not replicas added

#14 Updated by Vikhyat Umrao about 1 year ago

Nathan Cutler wrote:

@Vikhyat, I think Abhi just created the luminous backport tracker manually. The jewel one will be created automagically when I next run the script.

Thanks Nathan.

#15 Updated by Nathan Cutler about 1 year ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF