Project

General

Profile

Actions

Bug #17648

closed

Opensuse Tumbleweed: install-deps.sh succeeds but build fails due to missing dependency

Added by Jan Fajerski over 7 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

install-deps.sh uses 'rpmspec -q --buildrequires ceph.spec' to get a list of dependencies that must be installed. On opensuse systems this list does not contain the packages 'lttng-ust-devel' and 'babeltrace-devel'. A following make fails due to missing dependency.

install-deps.sh:128 The call to rpmspec does not list the packages in question.

Actions #1

Updated by Nathan Cutler over 7 years ago

since openSUSE does not have lttng or babeltrace, you need to run cmake with

-DWITH_LTTNG=OFF -DHAVE_BABELTRACE=OFF

IMO install-deps.sh is doing the right thing here

Actions #3

Updated by Kefu Chai over 7 years ago

  • Status changed from New to Rejected
Actions #4

Updated by Nathan Cutler over 7 years ago

  • Source changed from other to Community (dev)

The bottom line here is that if the lttng-ust-devel and babeltrace-devel packages are not available, install-deps.sh will never be able to install them.

So, if we know that we're on openSUSE we should provide the -DWITH_LTTNG=OFF -DHAVE_BABELTRACE=OFF options to cmake (install-deps.sh cannot do this).

I still think that cmake could detect (in a platform-independent way) whether lttng and babeltrace are available and set WITH_LTTNG and WITH_BABELTRACE accordingly (unless these values are set explicitly by the user). But checking for openSUSE is not the right way to do that - what if openSUSE starts shipping lttng and babeltrace at some later date?

Actions

Also available in: Atom PDF