Project

General

Profile

Actions

Bug #17266

closed

virtualenv default paths not uniquely named

Added by Dan Mick over 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

virtualenvs are used in the build for testing the various python projects. They're created, by default, in /tmp/<tool>-virtualenv. This means they collide when two builds happen on one host (shared build machine, multiple repos, whatever).

There doesn't seem to be any good reason not to use mktemp or something like it and completely avoid the possibility of collision.

Actions #1

Updated by Kefu Chai over 7 years ago

virtualenv directories is put under ${CEPH_BUILD_VIRTUALENV} in cmake, which is in turn /tmp by default. but one can always override it using the $TMPDIR env variable, the run-make-check.sh script actually creates a tmp directory using mktemp and expose it as $TMPDIR and pass it down to cmake.

so i think it is not an issue?

Actions #2

Updated by Sage Weil almost 7 years ago

  • Status changed from New to Closed
Actions #3

Updated by Dan Mick almost 7 years ago

This bites me every single time I build on a shared build machine; still think that at least /tmp/<username> is a better solution

Actions

Also available in: Atom PDF