Project

General

Profile

Actions
Copy link

Cleanup #16989

open

'rbd mirror pool' commands should report error if action not executed

Added by Jason Dillaman over 7 years ago. Updated about 6 years ago.

Status:
New
Priority:
Low
Assignee:
-
Target version:
-
% Done:

0%

Tags:
Backport:
jewel
Reviewed:
Affected Versions:
Pull request ID:

Description

Some examples:

1. rbd mirror pool enable <PoolName> pool :- Doesn't throw a warning message when the pool is already enabled

2. rbd mirror pool disable <PoolName> :- Doesn't throw a warning message when the pool is already disabled

3. rbd mirror pool enable pool1 image :- Changing the mode from pool to image or vice versa should throw a warning

Actions
Copy link
 #1

Updated by Jason Dillaman over 7 years ago

  • Status changed from New to Duplicate
Actions
Copy link
 #2

Updated by Jason Dillaman over 7 years ago

  • Status changed from Duplicate to New
Actions
Copy link
 #3

Updated by Rishabh Dave about 6 years ago

Looks like it's already resolved -

$ ./bin/rbd mirror pool enable rbd pool
$ ./bin/rbd mirror pool enable rbd pool
mirroring is already configured for pool mode
$ ./bin/rbd mirror pool disable rbd
$ ./bin/rbd mirror pool disable rbd
mirroring is already disabled

$ ./bin/rbd mirror pool enable rbd pool
$ ./bin/rbd mirror pool enable rbd image
note: changing mirroring mode from pool to image

$ ./bin/rbd mirror pool disable rbd

$ ./bin/rbd mirror pool enable rbd image
$ ./bin/rbd mirror pool enable rbd pool
note: changing mirroring mode from image to pool

Actions
Copy link
 #4

Updated by Rishabh Dave about 6 years ago

Sorry, I've checked against master and not jewel.

Actions
Copy link
 #5

Updated by Jason Dillaman about 6 years ago

... and make sure you test all "rbd mirror pool XYZ" commands, not just the three listed cases.

Actions
Copy link

Also available in: Atom PDF