Project

General

Profile

Actions

Bug #16481

closed

$ceph osd crush tunable hammer is NOT setting tunable profile to "hammer" and "straw_calc_version" to 1

Added by Vikhyat Umrao almost 8 years ago. Updated over 7 years ago.

Status:
Won't Fix
Priority:
High
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Support
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

`$ceph osd crush tunable hammer` is NOT setting tunable profile to "hammer" and "straw_calc_version": 1

# ceph osd crush tunables hammer

# ceph osd crush show-tunables 
{
    "choose_local_tries": 0,
    "choose_local_fallback_tries": 0,
    "choose_total_tries": 50,
    "chooseleaf_descend_once": 1,
    "chooseleaf_vary_r": 1,
    "straw_calc_version": 0, <--------------------
    "allowed_bucket_algs": 54,
    "profile": "unknown", <--------------------
    "optimal_tunables": 0,
    "legacy_tunables": 0,
    "require_feature_tunables": 1,
    "require_feature_tunables2": 1,
    "require_feature_tunables3": 1,
    "has_v2_rules": 1,
    "has_v3_rules": 0,
    "has_v4_buckets": 1
}

- Earlier I thought this could be a cosmetic bug not only setting the profile name but internally it has set the tunable to hammer.

# ceph osd crush tunables optimal
adjusted tunables profile to optimal

# ceph osd crush show-tunables 
{
    "choose_local_tries": 0,
    "choose_local_fallback_tries": 0,
    "choose_total_tries": 50,
    "chooseleaf_descend_once": 1,
    "chooseleaf_vary_r": 1,
    "straw_calc_version": 1, <-------------------
    "allowed_bucket_algs": 54,
    "profile": "hammer", <-------------------
    "optimal_tunables": 0,
    "legacy_tunables": 0,
    "require_feature_tunables": 1,
    "require_feature_tunables2": 1,
    "require_feature_tunables3": 1,
    "has_v2_rules": 1,
    "has_v3_rules": 0,
    "has_v4_buckets": 1
}

- But I have cross verified with setting optimal tunable and directly giving hammer tunable name has a difference which is nothing but as given in $subject.
"$ceph osd crush tunable hammer is NOT setting tunable profile to "hammer" and "straw_calc_version" to 1"

Actions #1

Updated by Vikhyat Umrao almost 8 years ago

  • Description updated (diff)
Actions #2

Updated by Vikhyat Umrao almost 8 years ago

Version : Red Hat Ceph Storage 1.3.2 (0.94.5-12.el7cp)

Actions #3

Updated by Vikhyat Umrao almost 8 years ago

- This tunable change was from 'argonaut' to 'hammer'.

Actions #4

Updated by Vikhyat Umrao almost 8 years ago

- looks like cosmetic bug only , as I have tested changing from 'hammer' to 'optimal' does not trigger any kind of rebalance.
- But we need to check why it is not setting "straw_calc_version" to 1.

Actions #5

Updated by Sage Weil almost 8 years ago

  • Status changed from New to Fix Under Review

https://github.com/ceph/ceph/pull/9956 fixes the hammer not showing optimal art (it was firefly!).

it is still necessary to set the straw_calc_version = 1 explicitly.

Actions #6

Updated by Samuel Just almost 8 years ago

  • Assignee set to Vikhyat Umrao
Actions #7

Updated by Samuel Just almost 8 years ago

  • Assignee changed from Vikhyat Umrao to Sage Weil
Actions #8

Updated by Sage Weil over 7 years ago

  • Status changed from Fix Under Review to Won't Fix
Actions

Also available in: Atom PDF