Project

General

Profile

Actions

Bug #16098

open

client.radosgw.* vs. client.rgw.*; incompabilities and confusion in code and documentation

Added by Jonas Eriksson almost 8 years ago. Updated almost 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Hello,

I have stumbled upon an inconsistency regarding the use of client.radosgw.* and client.rgw.* as the name of the radosgw daemons. In particular, I am having issues adding keyrings for client.radosgw.* using the bootstrap-rgw profile, since it only allows me to update/create client.rgw.* nodes.

See the imposed limitations of the profile in MonCap.cc:
https://github.com/ceph/ceph/blob/master/src/mon/MonCap.cc#L172

This is to be contrasted with most of the documentation; a quick git grep in the docs/ gives an indication (note: indication; the git grep is quite a rough tool in this case):

ceph/doc $ git grep 'client\.rgw\.' | wc -l
10
ceph/doc $ git grep 'client\.radosgw\.' | wc -l
75

It is also colliding with the default init scripts, which assumes that all radosgw:s are named client.radosgw.*:
https://github.com/ceph/ceph/blob/master/src/init-radosgw#L44-66
..which means that nodes added using the bootstrap-rgw key cannot be started using the shipped init script.

To solve this issue, I have two suggestions:
  • For currently released versions: Update the above init script to search for client.rgw.* in addition to client.radosgw.*; update MonCap.cc to allow changes to client.radosgw.* in addition to client.rgw.*
  • For some future version: Refactor all instances of client.rgw in the source and documentation to use client.radosgw instead.

I can implement these solutions and create a/some pull request(s) for any branches that you feel applicable for each solution if you wish, but will await any discussions before doing so.

Thanks,
/Jonas

Actions #1

Updated by Josh Durgin almost 7 years ago

  • Project changed from Ceph to rgw
Actions #2

Updated by Nathan Cutler almost 7 years ago

With the advent of systemd, the sysvinit scripts are no longer maintained. Which operating system+version are you using?

Actions #3

Updated by Jonas Eriksson almost 7 years ago

I was using the Ubuntu LTS version pre-systemd at that time. So if the init scripts are not maintained, I guess the problem is not as relevant any longer.

Actions

Also available in: Atom PDF