Project

General

Profile

Feature #15789

Give requested scrubs a higher priority

Added by Samuel Just over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
05/09/2016
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
kraken, jewel
Reviewed:
User Impact:
Affected Versions:
Release:
Needs Doc:
No

Description

It seems like requested scrubs will wait behind scheduled scrubs, that's not great. Since requested scrubs are already inserted into sched_scrub_pg with an immediate deadline they will be the next to start. Since we can't currently interrupt a scrub which is already in progress there is nothing more to do there. Later in the process we schedule actions with the same priority as regular scrubs. Increasing the priority should be helpful.


Related issues

Copied to Ceph - Backport #19685: kraken: Give requested scrubs a higher priority Resolved
Copied to Ceph - Backport #19686: jewel: Give requested scrubs a higher priority Resolved

History

#1 Updated by Wanlong Gao over 1 year ago

Samuel Just wrote:

It seems like requested scrubs will wait behind scheduled scrubs, that's not great.

Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)

#2 Updated by Wanlong Gao over 1 year ago

Wanlong Gao wrote:

Samuel Just wrote:

It seems like requested scrubs will wait behind scheduled scrubs, that's not great.

Samuel, do you mean requested replica scrub map? I find that the priority of requested replica scrub map op is PRIO_DEFAULT(127), it is higher than default scrub priority(5). So the requested scrub map will be processed first. But what do you mean? would you explain more? thank you. ;)

Ah, sorry, I understand the requested scrubs means "must_scrub".

#3 Updated by Wanlong Gao over 1 year ago

Trying to fix by PR: https://github.com/ceph/ceph/pull/10426 (closed)

#4 Updated by Samuel Just over 1 year ago

  • Tracker changed from Bug to Feature

#5 Updated by David Zafman 7 months ago

  • Status changed from New to In Progress
  • Assignee set to David Zafman

#6 Updated by David Zafman 7 months ago

  • Subject changed from make requested scrubs jump the queue to Give requested scrubs a higher priority
  • Description updated (diff)

#7 Updated by David Zafman 7 months ago

  • Status changed from In Progress to Pending Backport
  • Backport set to kraken, jewel

#8 Updated by Nathan Cutler 7 months ago

  • Copied to Backport #19685: kraken: Give requested scrubs a higher priority added

#9 Updated by Nathan Cutler 7 months ago

  • Copied to Backport #19686: jewel: Give requested scrubs a higher priority added

#10 Updated by Nathan Cutler 5 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF