Project

General

Profile

Bug #14838

Spelling error in ceph_disk/main.py

Added by Frode Sandholtbraaten about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
02/22/2016
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

With Ceph version 10.0.3-2171-gb8131f8 (b8131f893ae6f631debb8ca59e470ff919da7ec1):

root@compute01:/var/log/ceph# /etc/init.d/ceph start --cluster=pod01
Traceback (most recent call last):
File "/usr/sbin/ceph-disk", line 9, in <module>
load_entry_point('ceph-disk==1.0.0', 'console_scripts', 'ceph-disk')()
File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 4594, in run
main(sys.argv[1:])
File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 4548, in main
main_catch(args.func, args)
File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 4572, in main_catch
func(args)
File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 3425, in main_activate_all
if Ptype.is_dmcrpyt(tag, 'osd'):
AttributeError: type object 'Ptype' has no attribute 'is_dmcrpyt'

It seems like the "dmcrpyt" call is a spelling error. This bugs prohibits ceph osds from starting on Ubuntu 14.04.

Suggested quick fix:

diff --git a/src/ceph-disk/ceph_disk/main.py b/src/ceph-disk/ceph_disk/main.py
index 9447167..ce3f4e6 100755
--- a/src/ceph-disk/ceph_disk/main.py
+++ b/src/ceph-disk/ceph_disk/main.py
@@ -3422,7 +3422,7 @@ def main_activate_all(args):

         if tag in Ptype.get_ready_by_name('osd'):

-            if Ptype.is_dmcrpyt(tag, 'osd'):
+            if Ptype.is_dmcrypt(tag, 'osd'):
                 path = os.path.join('/dev/mapper', uuid)
             else:
                 path = os.path.join(dir, name)

Associated revisions

Revision ef6aafa8 (diff)
Added by Loic Dachary about 3 years ago

ceph-disk: s/dmcrpyt/dmcrypt/

http://tracker.ceph.com/issues/14838 Fixes: #14838

Signed-off-by: Frode Sandholtbraaten <>
Signed-off-by: Loic Dachary <>

History

#2 Updated by Loic Dachary about 3 years ago

  • Status changed from New to Need Review
  • Assignee set to Loic Dachary

#3 Updated by Loic Dachary about 3 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF