Bug #14797: osd: add all backfill osd to backfill_targets - Ceph - Ceph

Actions

Copy link

Bug #14797

closed

osd: add all backfill osd to backfill_targets

Added by Xinze Chi about 8 years ago. Updated almost 8 years ago.

Status:

Can't reproduce

Priority:

Urgent

Assignee:

Samuel Just

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

if pg_log.get_tail() > pi.last_update return true, it is possible that the peer is not in backfill_targets.
I am not sure whether it is right or not.

https://github.com/ceph/ceph/pull/7635

Files

osd.2.gz (491 KB) osd.2.gz

Xinze Chi, 02/19/2016 11:13 AM

Actions

Copy link

Updated by Samuel Just about 8 years ago

I don't understand how this can happen. When we start backfilling, we set pi.last_update to info.last_update (as part of activate). I think this patch is wrong and the bug you observed was something else. Please explain in more detail what is going on here.

Actions

Copy link

Updated by Xinze Chi about 8 years ago

For pg 1.7d
In timestamp 2016-02-11 23:40:51.235507 osd.2 is auth_log_shard and it's log_tail is 191'185, the last_update of osd.0 is 205'198, so the osd.0 is not selected as backfil_targets

But in 2016-02-11 23:40:51.238756 aften proc_replica_log, the last_update of osd.0 is down to 173'179, the last_update of osd.0(173'179 ) < the log_tail of osd.2(191'185)

so in PG::activate, the osd.0 is should be backfill, but is not in backfill_targets. so needs_backfill would return false, pg is not go to backfill state.

I upload some logs of osd.2

Please point out my mistakes if exits.

Thanks

Actions

Copy link