Project

General

Profile

Bug #14752

osd: agent can spin if in low flush mode and no evict work

Added by Sage Weil over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
Start date:
02/12/2016
Due date:
% Done:

0%

Source:
Community (user)
Tags:
Backport:
infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

if there isn't evict work, we will only start the low flush max ops, but won't go to sleep if we're below the high limit.

https://github.com/ceph/ceph/pull/7631


Related issues

Copied to Ceph - Backport #15161: infernalis: osd: agent can spin if in low flush mode and no evict work Rejected

Associated revisions

Revision 613457f9 (diff)
Added by Sage Weil over 3 years ago

osd: consider high/low mode when putting agent to sleep

If we are in low flush mode, we may only get up to max_low_ops in flight,
in which case we may never go to sleep here.

Fix it by using the max_low_ops threshold when appropriate.

Note that agent_work() might start up more than this many ops (if there
are lots of evicts to do) currently, but I think it is fine if evicts go
a bit slower if we are in low mode. (Really, the high/low shouldn't be
tied to flushing specifically.)

Fixes: #14752
Reported-by: Markus Blank-Burian <>
Signed-off-by: Sage Weil <>

History

#1 Updated by Sage Weil over 3 years ago

  • Status changed from Need Review to Pending Backport

#2 Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #15161: infernalis: osd: agent can spin if in low flush mode and no evict work added

#3 Updated by Loic Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF