Project

General

Profile

Actions

Bug #14706

closed

systemd escaping of block devices in ceph-disk incorrect

Added by James Page about 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
infernalis
Regression:
No
Severity:
2 - major
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph-disk currently does a replace on '-' to generate the name of the unit for the ceph-disk activation:

  1. http://www.freedesktop.org/software/systemd/man/systemd-escape.html
    escaped_dev = args.dev.replace('-', '\\x2d')
    service='ceph-disk@{dev}.service'.format(dev=escaped_dev)

however paths are dealt with a little differently with removal of the leading '/':

  1. systemd-escape /dev/vdb1
    -dev-vdb1
  1. systemd-escape -p /dev/vdb1
    dev-vdb1

This means OSD's don't get activiated under systemd 228 in Ubuntu xenial devel, as the escaped device is not recognised:

Feb 9 10:43:28 ubuntu systemd1: [/lib/systemd/system/ceph-disk@.service:2] Failed to resolve unit specifiers on Ceph disk activation: %f, ignoring: Invalid argument


Related issues 2 (0 open2 closed)

Related to Ceph - Bug #13954: ceph udev rules not used at boot.Can't reproduce12/02/2015

Actions
Copied to Ceph - Backport #14746: infernalis: systemd escaping of block devices in ceph-disk incorrectRejectedNathan CutlerActions
Actions #1

Updated by James Page about 8 years ago

Pull request raised to resolve this in master:

https://github.com/ceph/ceph/pull/7579

Actions #2

Updated by Sage Weil about 8 years ago

  • Status changed from New to 7
Actions #3

Updated by Sage Weil about 8 years ago

  • Related to Bug #13954: ceph udev rules not used at boot. added
Actions #4

Updated by Sage Weil about 8 years ago

  • Status changed from 7 to Pending Backport
  • Backport set to infernalis
Actions #5

Updated by Loïc Dachary about 8 years ago

  • Copied to Backport #14746: infernalis: systemd escaping of block devices in ceph-disk incorrect added
Actions #6

Updated by Loïc Dachary over 7 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF