Actions
Bug #14368
closedmon: paxos is_recovering calc error
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
ceph-deploy
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
enum { /** * Leader/Peon is in Paxos' Recovery state */ STATE_RECOVERING, /** * Leader/Peon is idle, and the Peon may or may not have a valid lease. */ STATE_ACTIVE, /** ...
/** * Check if we are recovering. * * @return 'true' if we are on the Recovering state; 'false' otherwise. */ bool is_recovering() const { return (state & STATE_RECOVERING); }
STATE_RECOVERING is 0 not 1 so should be
bool is_recovering() const { return (state == STATE_RECOVERING); }
Updated by Kefu Chai over 8 years ago
- Status changed from New to Fix Under Review
Updated by Kefu Chai over 8 years ago
- Status changed from Fix Under Review to Resolved
Actions