Project

General

Profile

Actions

Bug #14366

open

unsafe handle_conf_change() methods

Added by Josh Durgin over 8 years ago. Updated about 8 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The handle_conf_change() methods in these files look potentially unsafe (modifying data without locks):

mon/LogMonitor.cc
mon/Monitor.cc
os/keyvaluestore/KeyValueStore.cc
Actions #1

Updated by Kefu Chai about 8 years ago

as a complementary side note for whom wants more context of this issue

as this function is called from a thread, for example by injectargs(), while some other threads might be in the middle of reading the variables being changed.

Actions

Also available in: Atom PDF