Project

General

Profile

Bug #13943

ceph-disk: prepare with partition doesn't set or validate GUIDs

Added by David Disseldorp about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Low
Category:
-
Target version:
-
Start date:
12/01/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

"ceph-disk prepare" can be fed a block device (e.g. /dev/sda), or a partition (e.g. /dev/sda1) as a device argument.
When provided a block device argument, ceph-disk partitions the device, and sets the corresponding GPT GUIDS, based on whether the partition is data, journal, dmcrypt, etc.
However, if ceph-disk is a given partition device argument it leaves the GPT GUID as is, and doesn't check that the partition's GPT GUID matches the prepared partition type. As a result, components that rely on the partition GUID (e.g. udev) may fail.

I plan on proposing a patch that dumps a loud warning if "ceph-disk prepare" is called with a partition device argument, and the partition device's GUID doesn't match the expected Ceph reserved value.

Associated revisions

Revision 5ca41e1d (diff)
Added by David Disseldorp about 3 years ago

ceph-disk: warn for prepare partitions with bad GUIDs

If ceph-disk is a given partition device argument for prepare, it leaves
the GPT GUID as is and doesn't check whether the partition's existing
GUID matches the expected value. Print a warning in such cases.

Fixes: #13943

Signed-off-by: David Disseldorp <>

History

#1 Updated by David Disseldorp about 3 years ago

David Disseldorp wrote:
...

I plan on proposing a patch that dumps a loud warning if "ceph-disk prepare" is called with a partition device argument, and the partition device's GUID doesn't match the expected Ceph reserved value.

Proposed via:
https://github.com/ceph/ceph/pull/6760

#2 Updated by Loic Dachary about 3 years ago

  • Status changed from New to Need Review

#3 Updated by Loic Dachary about 3 years ago

  • Status changed from Need Review to Resolved

Also available in: Atom PDF