Project

General

Profile

Actions

Feature #13316

closed

cephfs-data-scan: delete unlinked file objects

Added by John Spray over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
fsck/damage handling
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
Labels (FS):
Pull request ID:

Description

Two types:
1 Non-0th data objects who have no 0th object
2 0th data objects that were not tagged in the latest forward scrub pass.

On reflection, we probably don't need to do case 2 here, because we already have the ability to inject those files as lost+found. This is good, because otherwise case 2 would be extremely dangerous (any failure to tag in the forward scrub would result in deletion). So probably just implement case 1: iterate over all non-0th objects, check if the 0th object for that inode exists, if it doesn't, remove this object. Emit lots of warnings and require some kind of --i-am-sure flag!

Actions #1

Updated by John Spray over 8 years ago

  • Status changed from New to Closed

Oh, never mind. I just realised that we never have this case, because during scan_extents we'll always create the 0th object if it doesn't exist, as a place to store the max size and max mtime fields. That will end up getting injected into lost+found, so user can delete it themselves.

Actions

Also available in: Atom PDF