Bug #12812
closedSomething fails to collect rocksdb sources for dist
0%
Description
Originally, this started because the current RPM spec cannot be used to build 0.94 (either in-tree ceph.spec.in or the one used to build the latest Fedora RPMs 0.94). In current tree, 9.0.2, "make dist" does not collect the src/rocksdb into the tarball. If this tarball is used to build with --with-librocksdb-static=check, then the build fails once it attempts to build rocksdb.
An easy fix here is to tell everyone stop using rocksdb and update the in-tree spec to drop that flag.
A more proper fix would be to tinker with autoconf so that "make dist" collects necessary source. Surprisingly, just including src/Makefile-rocksdb does not cut it. All the sources get added to ac_librocksdb_la_SOURCES as expected, but they somehow still miss from the tarball.
Updated by Ken Dreyer over 8 years ago
The tarballs for v0.94 and v0.94.3 both include src/rocksdb:
wget http://ceph.com/download/ceph-0.94.tar.bz2 tar --list -f ceph-0.94.tar.bz2 | grep src/rocksdb
What am I missing?
Updated by Pete Zaitcev over 8 years ago
I'm talking about the trunk tarball here, on 0.94. But strangely, I just tried it on 9.0.3 and "make dist" works as expected. Oh, well.
Updated by Pete Zaitcev over 8 years ago
BTW, it appears that there's no way for me to dispose of an invalid issue.
Updated by Sage Weil over 8 years ago
- Status changed from New to Rejected
see Makefile-rocksdb.am for hte hacky way that this is include din 'make dist' with autotools. NOte that i am pulling us up to rocksdb 3.11 on master which adds a zillion files.
also, this problem and that hack goes away once we switch to the make_dist.sh script.