Bug #12120: Remove build warnings from master branch - Ceph - Ceph

Actions

Copy link

Bug #12120

closed

Remove build warnings from master branch

Added by Vikhyat Umrao almost 9 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Sage Weil

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

1. crush/CrushTester.cc: In member function 'virtual void {anonymous}::CrushWalker::dump_item(const CrushTreeDumper::Item&, {anonymous}::CrushWalker::DumbFormatter*)':
crush/CrushTester.cc:411:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (max_id > 0 && qi.id >= max_id) {
^

2. client/Client.cc: In member function 'int Client::_preadv_pwritev(int, const iovec*, int, int64_t, bool)':
client/Client.cc:7496:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (resid < iov[j].iov_len) {
^
client/Client.cc:7490:18: warning: unused variable 'rlen' [-Wunused-variable]
uint32_t rlen = 0;
^

3. tools/cephfs/TableTool.cc: In instantiation of ‘int TableHandlerOmap<A>::reset(librados::IoCtx*) [with A = SessionMapStore]’:
tools/cephfs/TableTool.cc:370:80: required from here
tools/cephfs/TableTool.cc:356:40: warning: ‘void librados::ObjectOperation::set_op_flags(librados::ObjectOperationFlags)’ is deprecated (declared at ./include/rados/librados.hpp:276) [-Wdeprecated-declarations]
op.set_op_flags(librados::OP_FAILOK);
^

We should align these variables to correct data type to remove warning from build