Project

General

Profile

Actions

Fix #11021

closed

radosgw-agent: breaks with a traceback if it cannot connect to a host

Added by Alfredo Deza about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This should be handled gracefully, no need to spit out a traceback:

radosgw-agent --test-server-host localhost --test-server-port 8888 --src-access-key SRC_ACCESS_KEY --src-secret-key SRC_SECRET_KEY --dest-access-key DEST_ACCESS_KEY --dest-secret-key DEST_SECRET_KEY http://localhost:8888
2015-03-04 10:59:23,975 54707 [root][ERROR ] Could not retrieve region map from destination
Traceback (most recent call last):
  File "/Users/alfredo/python/radosgw-agent/radosgw_agent/cli.py", line 309, in main
    region_map = client.get_region_map(dest_conn)
  File "/Users/alfredo/python/radosgw-agent/radosgw_agent/client.py", line 428, in get_region_map
    region_map = request(connection, 'get', 'admin/config')
  File "/Users/alfredo/python/radosgw-agent/radosgw_agent/client.py", line 133, in request
    _retries=_retries)
  File "/Users/alfredo/python/radosgw-agent/radosgw_agent/request.py", line 157, in make_request
    override_num_retries=_retries
  File "/Users/alfredo/.virtualenvs/agent/lib/python2.7/site-packages/boto-2.34.0-py2.7.egg/boto/connection.py", line 1072, in make_request
    retry_handler=retry_handler)
  File "/Users/alfredo/.virtualenvs/agent/lib/python2.7/site-packages/boto-2.34.0-py2.7.egg/boto/connection.py", line 944, in _mexe
    request.body, request.headers)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 974, in request
    self._send_request(method, url, body, headers)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1008, in _send_request
    self.endheaders(body)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 970, in endheaders
    self._send_output(message_body)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 829, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 791, in send
    self.connect()
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 772, in connect
    self.timeout, self.source_address)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 571, in create_connection
    raise err
error: [Errno 61] Connection refused
Actions #1

Updated by Alfredo Deza about 9 years ago

Working with logging improvements the above now looks a bit like:

(agent)papaya-2[wip-10852*] ~/python/radosgw-agent ? radosgw-agent --test-server-host localhost --test-server-port 8888 --src-access-key SRC_ACCESS_KEY --src-secret-key SRC_SECRET_KEY --dest-access-key DEST_ACCESS_KEY --dest-secret-key DEST_SECRET_KEY http://localhost:8888
2015-03-04 15:07:55,497 55933 [radosgw_agent.client][ERROR ] unable to connect to localhost:8888 [Errno 61] Connection refused
Actions #2

Updated by Alfredo Deza about 9 years ago

  • Status changed from New to Fix Under Review
Actions #3

Updated by Alfredo Deza about 9 years ago

  • Status changed from Fix Under Review to Resolved

merged commit fdedc4d into master

Actions

Also available in: Atom PDF