Project

General

Profile

Actions

Bug #11015

closed

crushtool unable to compile map that includes buckets using straw2

Added by David Clarke about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

# ceph --version
ceph version 0.93 (bebf8e9a830d998eeaab55f86bb256d4360dd3c4)

# crushtool --outfn testmap --build --num_osds 1 host straw2 1 default straw2 0
2015-03-04 12:23:32.198491 7ff0ae3c37c0  1
ID      WEIGHT  TYPE NAME
-2      1.00000 default default
-1      0               host host0
0       0                       osd.0

# crushtool -d testmap -o testmap.txt

# cat testmap.txt
# begin crush map
tunable choose_local_tries 0
tunable choose_local_fallback_tries 0
tunable choose_total_tries 50
tunable chooseleaf_descend_once 1
tunable straw_calc_version 1

# devices
device 0 device0

# types
type 0 device
type 1 host
type 2 default

# buckets
host host0 {
        id -1           # do not change unnecessarily
        # weight 1.000
        alg straw2
        hash 0  # rjenkins1
        item device0 weight 0.000
}
default default {
        id -2           # do not change unnecessarily
        # weight 1.000
        alg straw2
        hash 0  # rjenkins1
        item host0 weight 0.000
}

# rules
rule replicated_ruleset {
        ruleset 0
        type replicated
        min_size 1
        max_size 10
        step take default
        step chooseleaf firstn 0 type host
        step emit
}

# crushtool -c testmap.txt -o testmap.compiled
testmap.txt:16 error: parse error at '# buckets'
Actions #1

Updated by Yann Dupont about 9 years ago

same here. Was reading the crushtool code, and it appears that , by default, straw2 is not enabled
but should if you put this :

tunable allowed_bucket_algs 54

(this is a bitmask , allowing default + STRAW2)

But it seems not sufficient.

Actions #2

Updated by Loïc Dachary about 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Loïc Dachary
  • Priority changed from Normal to Urgent
Actions #3

Updated by Sage Weil about 9 years ago

  • Status changed from In Progress to Fix Under Review
Actions #4

Updated by Loïc Dachary about 9 years ago

  • Assignee changed from Loïc Dachary to Sage Weil
Actions #5

Updated by Loïc Dachary about 9 years ago

  • Description updated (diff)
Actions #6

Updated by Yann Dupont about 9 years ago

tested wip-11015 branch and I can confirm it's working now. Thanks !

Actions #7

Updated by Sage Weil about 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF