Project

General

Profile

Actions
Copy link

Fix #10888

closed

`ceph osd` missing command gives incorrect suggestion

Added by Alfredo Deza about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kefu Chai
Category:
ceph cli
Target version:
-
% Done:

100%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When missing parameters/commands in the `osd` sub-command the output suggests incorrectly that I am required to use `pause`
when that isn't the case and can be confusing if the user wants to do something completely different.

$ sudo ceph osd
Invalid command:  missing required parameter pause
osd pause :  pause osd
Error EINVAL: invalid command
Actions
Copy link
 #1

Updated by Kefu Chai about 9 years ago

  • Assignee set to Kefu Chai
Actions
Copy link
 #2

Updated by Kefu Chai about 9 years ago

validate_command() list the "osd pause" as the best match of "osd", and ["osd"] fails to validate with this command signature. maybe we can take ["osd"] as an alias of ["osd", "--help"]?

Actions
Copy link
 #3

Updated by Kefu Chai about 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF