Project

General

Profile

Actions
Copy link

Feature #10046

closed

run make check on every pull request

Added by Loïc Dachary over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Loïc Dachary
Category:
-
Target version:
-
% Done:

100%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

And report back on the success / failure, with the logs attached for debugging. The suggested approach is to define a jenkins job that would leverage a github plugin to watch the pull request queue. The slaves would run make check after pulling the necessary dependencies, which may require an automated setup of the same kind as gitbuilder. Care should also be taken to encapsulate the run in a virtual machine / container that protects the infrastructure from code injection.

This ticket was open as the result of an IRC discussion between Alfredo Deza and Loic Dachary.

Actions
Copy link
 #1

Updated by Sage Weil over 9 years ago

  • Assignee set to Loïc Dachary
Actions
Copy link
 #2

Updated by Loïc Dachary over 9 years ago

  • Description updated (diff)
  • Assignee deleted (Loïc Dachary)

Removing myself and clarifying the scope. I would be happy to help with the implementation but I'm not equipped to take the lead.

Actions
Copy link
 #4

Updated by Loïc Dachary over 9 years ago

  • Status changed from New to 12

http://tracker.ceph.com/issues/10175 will make it possible to rely on the content of deps.deb.txt to install the required packages to compile on a virgin installation of the operating system. One step forward ;-)

Actions
Copy link
 #5

Updated by Loïc Dachary over 9 years ago

  • Status changed from 12 to In Progress
  • Assignee set to Loïc Dachary
Actions
Copy link
 #6

Updated by Loïc Dachary over 9 years ago

  • % Done changed from 0 to 40
Actions
Copy link
 #7

Updated by Loïc Dachary over 9 years ago

slave is gitbuilder-cdep-rpm-cloud-fedora20-amd64-basic.cloud.sepia.ceph.com

Actions
Copy link
 #9

Updated by Loïc Dachary over 9 years ago

  • % Done changed from 40 to 70

After thinking about it for a few days, it becomes clear that I do not have the necessary knowledge and motivation to maintain a jenkins job. I know too little about jenkins, have no experience in debugging problems with it, I know nothing about jenkins-job-builder either. I could probably learn enough to get the job running but fixing or improving it is another matter.

It turns out that a significant amount of work was needed just to figure out how to run make check reliably (see http://dachary.org/?p=3451) and this is mostly done. The other problem (how to integrate it in jenkins), will have to be done by someone else.

I will keep running and caring for the bot on rex003 semi-manually until someone has time / incentive to jenkins it ;-)

Actions
Copy link
 #10

Updated by Loïc Dachary over 9 years ago

  • % Done changed from 70 to 90

The bot has been running without incident for a few days. But activity is low and I'll wait until the end of the first week of january before declaring it stable.

Actions
Copy link
 #11

Updated by Loïc Dachary over 9 years ago

had to fix a) timeout, b) output overflow when rebuilding the container because its dependencies changed, c) fix failed build on dumpling because autogen.sh tries to cd rocksdb always

Actions
Copy link
 #12

Updated by Loïc Dachary over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

it has not caused trouble in the past week

Actions
Copy link

Also available in: Atom PDF