Activity
From 03/19/2012 to 04/17/2012
04/17/2012
- 10:33 PM Revision 4627b67f (ceph): msgr: Document remaining SimpleMessenger functions and data members
- This doesn't handle the inner classes (Pipe, mostly) yet. It also
raises questions about whether these functions shou... - 10:01 PM Revision 1f6b7f81 (ceph): msgr: Group the SimpleMessenger functions following the Messenger's pat...
- Ordering everything nicely will make for a cleaner interface, make
it easier to see what documentation we need, and m... - 08:22 PM Revision 3053e477 (ceph): Merge branch 'wip-2289-2'
- 08:20 PM Revision dcd34fc8 (ceph): FileJournal: let peek_write return a reference
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 08:17 PM Revision 65614847 (ceph): common: add blkdev.{h,cc}
- Signed-off-by: Sage Weil <sage@newdream.net>
- 08:12 PM Revision 82d7a681 (ceph): rbd: fix probe of source when block device
- Fixes: #2304
Signed-off-by: Sage Weil <sage@newdream.net> - 08:11 PM Revision 41cb40ad (ceph): filestore: factor block device size probe out into helper
- Signed-off-by: Sage Weil <sage@newdream.net>
- 07:56 PM Revision dea85368 (ceph): FileJournal: clarify locking in header
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 07:53 PM Revision 377f75f9 (ceph): OpRequest: mark_event output is now at debug 5
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 06:39 PM Revision 98e2369e (ceph): librados: add methods to check and wait for safe/complete -and- callback
- Allow user to check for (safe|complete) -and- callback return, and wait
for that condition.
Fixes: #2301
Signed-off-... - 06:17 PM Revision 001aa462 (ceph): msgr: add a little detail to mark_down_on_empty() and mark_disposable()
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 05:53 PM Revision 2eb2aa5a (ceph): msgr: group functions more appropriately
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 05:53 PM Revision a422c479 (ceph): msgr: remove out-of-date comments and function
- I think that destroy() is left over from a misinformed attempt
to implement refcounting on the Messenger.
Signed-off... - 05:45 PM Revision 0be9718a (ceph): librbd: 'rbd cache enabled' -> 'rbd cache'
- 'enabled' is useless verbiage. We should fix the rgw option too,
protably...
Signed-off-by: Sage Weil <sage@newdrea... - 03:59 PM Revision e875b89f (ceph): Add task for running fsx on an rbd image.
- 01:33 PM Revision 6cbda4c3 (ceph): qa: comment out xfstest 232
- Test 232 in the xfstests suite produces an XFS error in the log
when run over an RBD device. This is most likely an ... - 07:14 AM Revision e0ec2865 (ceph): objecter: recalc pgid in case it wasn't a precalculated pgid
- We had an issue where we didn't call it since we relied on the
existance of the object name and we were passed an emp... - 07:12 AM Revision f22da6c0 (ceph): cls_rgw: rgw_dir_suggest_changes move cur_disk_bl inside loop
- Otherwise we'd fail in case the cls_cxx_read_key failed, since
we rely on its size.
Signed-off-by: Yehuda Sadeh <yeh... - 04:36 AM Revision 998498f2 (ceph): Merge branch 'wip-oc-perf'
- 04:32 AM Revision 31d0d1d7 (ceph): librados: test get_pool_name
- Signed-off-by: Sage Weil <sage@newdream.net>
- 04:32 AM Revision 2dbea128 (ceph): librados: C bindings for get_pool_name()
- Signed-off-by: Sage Weil <sage@newdream.net>
04/16/2012
- 09:21 PM Revision 9f5b9ada (ceph): Merge remote branch 'upstream/wip-guard'
- 09:19 PM Revision 2f5af83f (ceph): Filestore: fix guard errors in COLL_REMOVE and COLL_MOVE
- Use object rather than collection check in COLL_REMOVE. Adjust
COLL_MOVE check for -1/1 distinction.
Signed-off-by:... - 07:32 PM Revision f87a6a0f (ceph): cls_rgw: rgw_dir_suggest_changes() don't try to decode cur_disk
- don't try to decode cur_disk if bufferlist is zero sized.
Signed-off-by: Yehuda Sadeh <yehuda.sadeh@dreamhost.com> - 07:32 PM Revision 6868ec6a (ceph): rgw: skip empty entries when listing a bucket
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 07:32 PM Revision 73badda6 (ceph): cls_rgw: don't zero out error code before reading value
- We were zeroing the return code before reading it.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 03:39 AM Revision 6bede298 (ceph): dump_stuck: whitelist 'wrongly marked me down'
- The test marks the osds down.. they may generate this error if they get
that faster than they get the signal via the ...
04/14/2012
- 10:38 PM Revision 1bc01289 (ceph): Merge branch 'stable'
- 09:06 PM Revision 19e673cc (ceph): filestore_idempotent: use new sequence-based tester
- random seed, inject at 50-300.
- 08:53 PM Revision 20ab74ea (ceph): test_librbd: fix write sizes
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:26 PM Revision 81c8a7b9 (ceph): test_idempotent_sequence: no config file
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 04:43 PM Revision a40fe5bd (ceph): run_xfstests.sh: ensure cleanup on errors
- Because we exit on any error (due to 'set -e'), the cleanup call was
never getting made in the event of an error. Th... - 04:26 PM Revision 3d187db5 (ceph): run_xfstests.sh: pass test result via exit status
- It turns out that xfstests *does* exit with non-zero status
when a test fails. Its exit status is the number of test... - 06:53 AM Revision a4dd9204 (ceph): objclass: fix cls_cxx_map_remove_key()
- didn't set the correct osd op, didn't do anything.
Signed-off-by: Yehuda Sadeh <yehuda.sadeh@dreamhost.com> - 06:10 AM Revision b352a3e1 (ceph): rgw: call dir_suggest_changes with correct bufferlist
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 05:28 AM Revision 6ba4efcd (ceph): rbd.py: add xfstests functionality
- Add tasks for running xfstests over a pair of rbd volumes. The main
one is called xfstests, and it sets up rbd volum... - 05:27 AM Revision 4498825a (ceph): add rbd_xfstests to regression suite
- 05:19 AM Revision a31392cf (ceph): objectcacher: name them
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:18 AM Revision 28e61811 (ceph): librados: add IoCtx::get_pool_name() to c++ api
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 04:51 AM Revision 446b5e24 (ceph): ObjectCacher: move functions out of the header.
- These all set off my "big-functions-in-the-header" alarm.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 04:51 AM Revision 6257a94e (ceph): ObjectCacher: add a bunch of perfcounters
- Hurray, we can collect cache statistics!
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 04:51 AM Revision f355875b (ceph): ObjectCacher: group all the function definitions properly
- Some of the ObjectCacher functions were separate, which works poorly
if you're trying to do things like use ldout.
S... - 04:51 AM Revision d80c126a (ceph): ObjectCacher: use "objectcacher" instead of the CephContext::name for p...
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 04:51 AM Revision 72a75730 (ceph): objectcacher: perf skeleton
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
Conflicts:
src/osdc/ObjectCacher.cc
src/osdc/ObjectCacher.h - 04:41 AM Revision 2cc854f7 (ceph): msgr: Document all the functions in the Messenger interface.
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 04:40 AM Revision b8207dd2 (ceph): msgr: remove several functions from the interface.
- The suicide() function is unused and its current SimpleMessenger
implementation just calls shutdown(). And I don't se... - 04:02 AM Revision bf8847e7 (ceph): qa: add run_xfsests.sh script
- Add a script that runs xfstests over a pair of devices that are
specified using command line arguments. The tests ar... - 04:01 AM Revision ee69f271 (ceph): test/rbd/fsx: fix signed/unsigned warnings
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:52 AM Revision 812c7c7a (ceph): librbd: implement discard
- Implement sync and async discard. Embed an ObjectWriteOperation in the
BlockCompletion struct.
The sync version doe... - 03:51 AM Revision 589c6269 (ceph): Merge branch 'wip-librbd-caching'
- Reviewed-by: Sage Weil <sage.weil@dreamhost.com>
- 03:46 AM Revision 5c2d5b18 (ceph): test: copy fsx to rbd directory
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision b26d7024 (ceph): test: port fsx to run on an rbd image instead of a file
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 78d14da8 (ceph): librbd: flush pending writes when a new snapshot is created
- This makes sure the state is as consistent as librbd can make it
before the snapshot is actually created.
Signed-off... - 03:46 AM Revision 30805bfa (ceph): test_librbd_fsx: clean up properly
- Delete and close everything on exit.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com> - 03:46 AM Revision 68e2e004 (ceph): librbd: flush cache before creating a snapshot
- This is a temporary workaround until the ObjectCacher
is smarter about snapshots.
Signed-off-by: Josh Durgin <josh.d... - 03:46 AM Revision d0b1f72c (ceph): ObjectCacher: add some asserts about when the lock is held
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 7197825d (ceph): Remove unused Completion.h header
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 1dd9c303 (ceph): ObjectCacher: remove redundant 'public:'
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 7868dbe0 (ceph): ObjectCacher: remove unused/unimplemented methods
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision ee9987b2 (ceph): librados: debug logging for aio writes
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 20be92ec (ceph): ObjectCacher: always delete callback in commit_set
- The GatherBuilder used later always deletes it. To make
the interface sane, delete it in every return path.
Signed-o... - 03:46 AM Revision 6cf22655 (ceph): ObjectCacher: remove useless conditional
- We assert this condition at the beginning of the function.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com> - 03:46 AM Revision 55b65544 (ceph): test_librbd: flush before opening another handle to the image
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision d9aa81b0 (ceph): finisher: add indent settings header
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision f464e6c3 (ceph): ObjectCacher: include object when outputting a BufferHead
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision 9c8b3f70 (ceph): .gitignore: clean up to not match so many things recursively
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
- 03:46 AM Revision a0fc3336 (ceph): librados: unconditonally associate IoCtxImpl with AioCompletionImpl
- We were only setting the pointer if we were on the aio_write_list. Set
this pointer for any aio.
Signed-off-by: Sag... - 03:46 AM Revision 34a10fae (ceph): librados: do aio callbacks in async thread
- Call user completions in an async thread. This allows callers to call back
into librados from the callback, and allo... - 03:46 AM Revision cbbd5f97 (ceph): ObjectCacher: check for read/write errors
- The objecter doesn't fix every error for us.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com> - 03:46 AM Revision abbfd937 (ceph): Filer: make file_to_extents static
- Now the ObjectCacher has no need for a Filer instance (not that
it had a good reason for one before).
Signed-off-by:... - 03:46 AM Revision d6dbff01 (ceph): ObjectCacher: remove dependency on Objecter
- Abstract out how writeback is done with a WritebackHandler object.
For RBD caching, this will be done by librados, bu... - 03:46 AM Revision 9546c158 (ceph): librbd: remove writeback window
- This is superseded by a full-fledged writeback cache.
Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com> - 03:46 AM Revision c0073770 (ceph): librbd: allow writeback caching
- This uses the existing infrastructure of ObjectCacher for
buffer management and expiry.
Signed-off-by: Josh Durgin <... - 03:46 AM Revision 579d30b6 (ceph): librbd: check for writes to snapshots
- librados does this for us normally, but caching does not check for this.
We might as well check early to avoid schedu... - 03:46 AM Revision bb35ecf0 (ceph): librbd: fix bytes read accounting in read_iterate
- ObjectCacher will never do short reads, and always returns 0.
librados may do short reads at the end of an object.
S... - 03:41 AM Revision cc1ae672 (ceph): filestore: flush log on failure injection
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:41 AM Revision ad2eba43 (ceph): Merge branch 'wip-2226b'
- Conflicts:
src/common/config_opts.h
src/os/FileStore.cc
src/os/FileStore.h - 03:38 AM Revision 4fc48e5b (ceph): run_seed_to_range.sh: run filestore idempotent sequence tests over a range
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision f052c82b (ceph): run_seed_to: assume tool is in path, not cwd
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 2cb0032e (ceph): DeterministicOpSequence: writing to object being cloned in the same tx.
- We write to the object being cloned prior to the clone to ensure we are
cloning a valid range of bytes.
The write an... - 03:38 AM Revision c7729847 (ceph): test_idempotent_sequence: simple test script
- Takes seed and kill point, then verifies the result.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 03:38 AM Revision 95bb4239 (ceph): filestore: use our assert
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision a8b9b98c (ceph): run_seed_to.sh: set -e
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 56fb027f (ceph): test_idempotent_sequence: make get-last-op return 0 if no txns applied
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 2d24eb33 (ceph): FileStore: don't return ENOENT from object_map getters
- ENOENT in those contexts means that the object_map does not know
about the object, not that the object does not exist... - 03:38 AM Revision 21be4ad9 (ceph): test_idempotent_sequence: Add more info on diff's dout's.
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision bb0499a4 (ceph): test_idempotent_sequence: outputting collection being diff'ed.
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 27cb82e5 (ceph): test_idempotent_sequence: use get_obj_at() for clone source
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 1b451294 (ceph): test_idempotent_sequence: fix/enable do_coll_add
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision a5f533a7 (ceph): test_idempotent_sequence: fix diff return value, mount behavior
- No mkfs!
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 03:38 AM Revision 08cf4d28 (ceph): test_idempotent_sequence: include object name in diff output
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 2d20b4c2 (ceph): test_idempotent_sequence: return true from diff if different
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 5d30581e (ceph): test_idempotent_sequence: add remove op
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision e270e0b5 (ceph): test_idempotent_sequence: diff two stores.
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 2c940a4f (ceph): test_idempotent_sequence: Remove references to VerifyFileStore
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 42899110 (ceph): Makefile: remove VerifyFileStore from test_idempotent_sequence build
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 84175c7d (ceph): VerifyFileStore: delete from tree
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 794fc0b6 (ceph): test_idempotent_sequence: fix collection_move arg order
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision a8c32057 (ceph): test_idempotent_sequence: whitesepace
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision bc5dffe9 (ceph): test_idempotent_sequence: replace on coll_move
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision c056f603 (ceph): test_idempotent_sequence: simplify clone
- - pick existing source
- any target is ok, as long as it != source
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 03:38 AM Revision 51bc6dfd (ceph): test_idempotent_sequence: make object names overlap
- This way when we move objects between collections they will replace
each other in interesting ways.
Signed-off-by: S... - 03:38 AM Revision db3d14b9 (ceph): test_idempotent_sequence: fewer objects per collection by default
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision bec1e50e (ceph): test_idempotent_sequence: remove existing target for collection_add
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 975e59ad (ceph): test_idempotent_sequence: Add commands and lose a couple of optional args.
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:38 AM Revision 5ced86be (ceph): filestore: init filestore_kill_at in ctor
- Otherwise we don't get the option for FileStore instances created after
common_init_finish() (which does md_config_t:... - 03:38 AM Revision 9dba3172 (ceph): test_idempotent_sequence: require nonexistent filestore dir
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 795274bc (ceph): test_idempotent_sequence: include tx number in each transaction
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 57866946 (ceph): test_idempotent_sequence: implement get-last-op
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision 6573690a (ceph): VerifyFileStore: Check if two FileStore's match after applying a set of...
- With DeterministicOpSequence we are able to reproduce exactly the same
sequence of operations, over and over. However... - 03:38 AM Revision dee47bb2 (ceph): test_idempotent_sequence: Generate a reproducible sequence of txs.
- With this test we aim at reproducing the same sequence of transactions
as long as we are provided with the same seed ... - 03:38 AM Revision 4a6cfcb3 (ceph): deterministicopseq: add collection_rename() support
- 03:38 AM Revision 01daa88d (ceph): test_idempotent_sequence: no need to reinject value that is already there
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:38 AM Revision a5a83950 (ceph): filestore: name internally
- We need to allow the perfcounter name to be controlled so that we can have
two instances of FileStore in the same pro... - 03:38 AM Revision 83227550 (ceph): TestFileStoreState: Represent a FileStore's state to be used by tests.
- Instead of having each test creating the same representation of a
FileStore's state, with a map/set of collections an... - 03:38 AM Revision 2f02a8a5 (ceph): DeterministicOpSequence: Generate a reproducible sequence of operations.
- Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
- 03:33 AM Revision 583c79af (ceph): filestore: fix collection_add argument names
- No functional changes, just fixing and clarifying argument names so that it
is less confusing/wrong.
Signed-off-by: ... - 03:33 AM Revision dfcadc94 (ceph): filestore: simple failure injections via --filestore-kill-at <n>
- This will make filestore suicide (_exit(1)) on the n'th potential failure
call site. We can potentially fail:
... - 03:33 AM Revision f4001790 (ceph): filestore: two-phase guard
- For certain operations (collection_add) we need a two-phase guard, and an
"in-progress" state.
- before exposing an... - 03:33 AM Revision 8d3acb5a (ceph): filestore: replay collection_move using add+remove
- This approximates the buggy collection_move. It is still buggy. It is
only there to replay old journals.
Rip out b... - 01:14 AM Revision c6551fb8 (ceph): test_rados.py: add basic tests for the Object class
- Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
Reviewed-by: Greg Farnum <gregory.farnum@dreamhost.com> - 01:13 AM Revision 76799680 (ceph): rados.py: fix Object.read argument order
- 57cfd7673da66d191cc397689da35d0a1f3dc61a switched the argument order but didn't change this caller.
Signed-off-by: T...
04/13/2012
- 11:12 PM Revision 5ce8d71f (ceph): FileJournal: allow write_thread and write_finisher to run in parallel
- Previously, the write_thread and the write_finisher serialized on
write_lock limiting performance. aio_lock has been... - 05:46 PM Revision dc44950b (ceph): filestore: implement collection_move() as add + remove
- This ensures we get add and remove steps with different spos values, which
makes the guard work. The collection_move... - 04:59 PM Revision dc10d04e (ceph): OSD: improve information and format of OSDTracker messages
- Also, Message now has a timestamp indicating when the message
was fully recieved for use by OSDTracker.
Signed-off-b... - 06:16 AM Revision 3d11455b (ceph): osdmaptool: fix clitest for lpg_num 0
- Broke this in 11b93d3af2c0f1bca3e48fe773a14f07f479ccc3
Signed-off-by: Sage Weil <sage@newdream.net> - 05:56 AM Revision 55535d04 (ceph): move tasks:cfuse_workunit_suites_dbench.yaml to stress pending #1737 fix
- 05:36 AM Revision 1e76a871 (ceph): Merge remote branch 'gh/wip-defaults'
- 04:47 AM Revision 8a6c3c17 (ceph): msgr: dispatcher: Documentation of security functions
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
04/12/2012
- 11:24 PM Revision 9b2aff20 (ceph): FileStore: don't return ENOENT from object_map getters
- ENOENT in those contexts means that the object_map does not know
about the object, not that the object does not exist... - 10:50 PM Revision 241c5e5e (ceph): msgr: Reorder functions to reduce the number of privacy tags.
- No functional changes.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 10:45 PM Revision 5cf7628f (ceph): msgr: miscellaneous fixes.
- Indentation on a public label; various function documentation; remove
an inappropriate definition of a virtual functi... - 10:17 PM Revision 8e5f5625 (ceph): DBObjectMap: check in clone and link that source is not destination
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 07:16 PM Revision a5730c85 (ceph): Merge branch 'wip-2223'
- Reviewed-by: Sage Weil <sage@newdream.net>
- 05:59 PM Revision 9565a8ba (ceph): ObjectStore: Remove code duplication when dumping transactions.
- By using OStreamFormatter, we can have a single function responsible for
dumping a transaction. We keep the same old ... - 05:59 PM Revision ddbaf584 (ceph): filestore: remove commented code, fix whitespace
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:59 PM Revision 7223f00a (ceph): filestore: dump transactions sets, include seq and trans_num
- Lists of transactions commit as a unit; reflect that in the dump. Also
include seq and trans_num.
Signed-off-by: Sa... - 05:59 PM Revision 816a5128 (ceph): objectstore: tweak dump() a bit
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:59 PM Revision 308c1fc6 (ceph): filestore: use config observer to start/stop dumping/tracing
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:59 PM Revision 6ee0b718 (ceph): filejournal: dump injson
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:59 PM Revision 6a7bbe86 (ceph): filestore: dump transaction in json on error
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 12:38 AM Revision cfac4a97 (ceph): pgmon: clear out osd reports after the OSD has gone down
- Previously we never removed report times from last_osd_report. Do
so, in check_osd_map (which, on the leader, is call...
04/11/2012
- 11:00 PM Revision 119dd5ae (ceph): mkcephfs: update man page
- Signed-off-by: Sage Weil <sage@newdream.net>
- 11:00 PM Revision 4a4b7994 (ceph): ceph-authtool: update man page
- Signed-off-by: Sage Weil <sage@newdream.net>
- 10:53 PM Revision ab08fb8b (ceph): mkcephfs: note that btrfs (and --mkbtrfs) are optional and experimental
- And that --mkbtrfs will be deprecated soon.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 10:53 PM Revision ee39291a (ceph): ceph-authtool: add warning to man page
- - data is not encrypted over the wire
- intended for trusted environments
Signed-off-by: Sage Weil <sage.weil@dreamh... - 10:40 PM Revision 11b93d3a (ceph): osd: disable localized pgs by default
- Signed-off-by: Sage Weil <sage@newdream.net>
- 10:40 PM Revision 8836b81f (ceph): mon: alloc pgp_num adjustment up and down
- Signed-off-by: Sage Weil <sage@newdream.net>
- 10:39 PM Revision 83e1260b (ceph): mon: set pgp_num == pg_num (by default) for new pools
- For when pg_num is specified but not pgp_num. Thanks Greg!
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 10:39 PM Revision 58671a4c (ceph): mon: command to disable localized pgs for a pool
- ceph osd pool disable_lpgs <poolname> --yes-i-really-mean-it
Grr, these should be off by default. We can't adjust t... - 08:35 PM Revision 7fdf25bc (ceph): debian: python-support -> dh_python2
- I followed the instructions on
http://wiki.debian.org/Python/TransitionToDHPython2
Signed-off-by: Sage Weil <sage@... - 07:35 PM Revision ed0653b4 (ceph): COPYING: doc/ CC BY-SA
- Signed-off-by: Sage Weil <sage@newdream.net>
- 07:33 PM Revision 6e83e119 (ceph): README: update
- - refer to COPYING, SubmittingPatches
- a word about dependencies
- building packages
- drop the list of built binari... - 06:42 PM Revision 838a7618 (ceph): ceph-rbdnamer: include in dist tarball and debs/rpms
- Signed-off-by: Sage Weil <sage@newdream.net>
- 06:42 PM Revision af502735 (ceph): obsync: include man page in tarball, packages
- Signed-off-by: Sage Weil <sage@newdream.net>
- 06:42 PM Revision 9678c097 (ceph): init-radosgw: start in runlevel 4
- Fixes lintian error
W: radosgw: init.d-script-missing-start etc/init.d/radosgw 4
Signed-off-by: Sage Weil <sage@new... - 06:42 PM Revision 84efc554 (ceph): debian: drop unnecessary conflicts on librgw
- Cut and paste baggage from libcephfs, it looks like.
Signed-off-by: Sage Weil <sage@newdream.net> - 05:40 PM Revision 292898a8 (ceph): init-ceph: start at all runlevels
- This fixes lintian error:
W: ceph: init.d-script-missing-start etc/init.d/ceph 4
Signed-off-by: Sage Weil <sage@new... - 05:03 PM Revision b1946290 (ceph): Merge branch 'stable'
- 05:47 AM Revision be5b25b6 (ceph): filestore: fix collection_move guard
- We had a sequence like:
1- write A block 1
2- write A block 2
3- write A block 3
4- write A block 4
5- move A -... - 05:47 AM Revision 4bd9d1bb (ceph): filestore: fix collection_add guard
- If we crash between the link() and setting the guard, we will get
EEXIST. Tolerate that.
Signed-off-by: Sage Weil <... - 05:47 AM Revision df4d7a47 (ceph): filestore: fix collection_rename guard
- If we crash between the rename and setting the guard, we can get EEXIST
or ENOTEMPTY on rename. Tolerate that.
Sign... - 05:47 AM Revision 85db25e8 (ceph): filestore: fix fd leak on collection_rename
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:47 AM Revision c3e4c5b7 (ceph): filestore: cleanup: flip sense of replay guard check
- The other are all if (_check_replay_guard(..)) do_it;. Make this one
match.
Signed-off-by: Sage Weil <sage.weil@dre... - 05:43 AM Revision 43de5e4f (ceph): FileStore: dumping transactions to a file
- Dump each queued transaction to a predefined file, specified with
--filestore-dump-file, in JSON format.
Signed-off... - 05:43 AM Revision cd4a760e (ceph): osd: fix heartbeat set_port()
- set_port() fails an assert if it isn't an in4 or in6 address, which a
default entity_addr_t is not.
Signed-off-by: S... - 04:43 AM Revision 1775301b (ceph): osd: reenable clone on recovery
- This hasn't turned up problems in QA.
Fixes: #2002
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
04/10/2012
- 11:23 PM Revision ddb98f77 (ceph): ceph_manager: don't try to start greenlet twice
- spawn already scheduled it. Trying to start it again hits an assert.
- 11:11 PM Revision 6fbac10d (ceph): osd: allow users to specify the osd heartbeat server address.
- Reported-by: Nick Bartos <nick@pistoncloud.com>
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
Reviewed-by... - 09:56 PM Revision 4f030e1b (ceph): osd_types: fix off by one error in is_temp
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
Reviewed-by: Gregory Farnum <gregory.farnum@dreamhost.com> - 09:48 PM Revision 31f16a4c (ceph): rgw: list multipart response fix
- LastModified was formatted outside of the Part block.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 09:06 PM Revision 89fecda6 (ceph): Makefile.am: remove some clutter
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 08:41 PM Revision 1ac5554d (ceph): kernel: kludge around mysterious 0-byte .git/HEAD files
- No idea where these are coming from, but they break nodes with behavior
like
ubuntu@plana08:~$ sudo install -d -m075... - 05:42 PM Revision 0aea1cb1 (ceph): v0.45
- 04:17 PM Revision 0d5918f8 (ceph): kernel: reset to remote firmware branch; don't pull
- Pull might merge if upstream rebases. Just make our branch match the
remote one. - 04:12 PM Revision 9b755fd6 (ceph): kernel: change git incantation for firmware pull
- The 'git pull <uri>' seemed to consistently fail on some nodes. Can't be
sure this was really the problem with them ... - 03:59 PM Revision 22b1f17f (ceph): ls: another newline
- 03:57 PM Revision 7757fbb9 (ceph): ls: remote stray newline
- 04:22 AM Revision 965f83d4 (ceph): Merge branch 'next'
- 04:20 AM Revision d348e1ab (ceph): configure: --with-system-leveldb
- Default to bundled leveldb. Optionally check.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 04:20 AM Revision 34cc308e (ceph): filestore: fix leveldb includes
- Signed-off-by: Sage Weil <sage@newdream.net>
- 03:23 AM Revision 0b2e1cd2 (ceph): cephfs: fix uninit var warning
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
04/09/2012
- 11:58 PM Revision 9906d5ed (ceph): Change to local mirror of linux-firmware repo to try to stop failures
- 11:17 PM Revision f79b95e5 (ceph): Makefile: add missing .h to tarball
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 10:56 PM Revision 8d5c87a8 (ceph): rgw: fix object name with slashes when vhost style bucket used
- Fixes issue #2259. The problem was that we were initializing the
object name, then in the case of a virtual host buck... - 09:02 PM Revision 853b0458 (ceph): OSD: use per-pg temp collections, bug #2255
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 07:08 PM Revision 36d42dea (ceph): buffer: allow advance() to move an iterator backward
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 07:08 PM Revision bd518e99 (ceph): encoding: fix iterator use for struct_len copy_in
- The end() iterator position does not record an offset when the list is
modified.
Signed-off-by: Sage Weil <sage.weil... - 03:59 AM Revision 7951d7e4 (ceph): Merge remote branch 'gh/stable' into next
- 03:58 AM Revision dd8fd168 (ceph): configure: HAVE_FALLOCATE -> CEPH_HAVE_FALLOCATE
- /usr/include/linux/fs.h defines this on CentOS 5, even though it does not
in fact compile. This stupid workaround av...
04/06/2012
- 09:07 PM Revision 8e1cc8ab (ceph): init-ceph: manage pid_file from init script
- With upstart the daemon shouldn't manage the pid file itself. Move this
out of the default config and into the legac... - 08:48 PM Revision 81d2cbeb (ceph): config: move /var/run and /var/log defaults to config_opts.h
- This flips the sense of the common_init defaults. Before, the alternate
defaults were filled in if it was a daemon. ... - 08:39 PM Revision dfa043df (ceph): config: {osd,mon}_data default to /var/lib/ceph/$type/$cluster-$id
- Signed-off-by: Sage Weil <sage@newdream.net>
- 07:26 PM Revision 2ceda946 (ceph): Merge branch 'stable'
- 06:44 PM Revision 7680cdad (ceph): dencoder, rgw: make ceph-dencoder load much faster
- by avoiding linking with unneeded shared objects.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 05:00 PM Revision 98326968 (ceph): encoding: use iterator to copy_in encoded length
- This gives us a pointer to the position into the list where the final
length value will be copied. Previously we use...
04/05/2012
- 09:55 PM Revision 689ac5d7 (ceph): v0.44.2
- 09:53 PM Revision e0c4db9e (ceph): FileStore: do not check dbobjectmap without option set
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 09:25 PM Revision 38e24b1e (ceph): config: include /etc/ceph/$cluster.keyring in keyring search path
- mkcephfs and the docs etc still write to /etc/ceph/keyring.
Signed-off-by: Sage Weil <sage@newdream.net> - 09:25 PM Revision 57dff032 (ceph): config: expand metavariables for --show-config, --show-config-value
- Signed-off-by: Sage Weil <sage@newdream.net>
- 09:08 PM Revision 90e88a08 (ceph): Merge branch 'wip-cluster'
- Reviewed-by: Yehuda Sadeh <yehuda.sadeh@dreamhost.com>
- 08:35 PM Revision cfee0333 (ceph): config: parse fsid uuid in config, not ceph_mon
- Use the new OPT_UUID type.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 08:35 PM Revision 2c14c8b2 (ceph): config: add distinct UUID type
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 08:32 PM Revision 2c0dc47e (ceph): global: add -C or --cluster early args to specify cluster name
- This will let you specify which cluster to talk to on the command line
(e.g., 'ceph -C foo ...' or when starting a da... - 08:32 PM Revision 930a669a (ceph): config: add cluster name as metavariable; use for config locations
- Add a cluster name (default "ceph") to the config structure, and expand
$cluster in all config values.
Make the defa... - 08:25 PM Revision bda562fb (ceph): config: implement --show-config and --show-config-value <option>
- Dump internal config value(s) to stdout and then exit.
Signed-off-by: Sage Weil <sage@newdream.net> - 08:04 PM Revision f18b219a (ceph): test_workload_gen: fix logging
- Signed-off-by: Sage Weil <sage@newdream.net>
- 08:01 PM Revision 32b5d0f8 (ceph): config: remove obsolete bdev_* options
- These were part of ebofs.
Signed-off-by: Sage Weil <sage@newdream.net> - 07:59 PM Revision 1b769535 (ceph): Merge remote-tracking branch 'gh/wip-log'
- 06:43 PM Revision 0e5d087c (ceph): README: update instructions
- Needed to add submodule instructions.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 03:49 PM Revision 3d7f1db7 (ceph): Kernel: Pull linux-firmware from git
- Signed-off-by: Mark Nelson <nhm@clusterfaq.org>
04/04/2012
- 11:12 PM Revision 0df6fbd3 (ceph): rados: fix rados import
- This fixes issue #2253. Wrong param order to fread().
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 08:56 PM Revision ba0fb3ed (ceph): cleanup-and-unlock.sh: helper to nuke and then unlock a set of nodes
- I usually do something like
teuthology-lock --list-targets --owner scheduled_sage@metropolis > /tmp/b
./cleanup-an... - 08:54 PM Revision 3adf2bf9 (ceph): schedule_suite.sh: helper to schedule a suite
- There's a bunch of stuff hardcoded in here, similar to the nightly, but
it's a useful starting point. - 04:21 AM Revision 0921c062 (ceph): config: drop loud ERROR prefix
- This makes gitbuilder sad.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 12:03 AM Revision b9185bb2 (ceph): osdmap: allow row, room, datacenter, pool in conf for initial crush map
- These work just like host and rack, except that they are optional.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 12:02 AM Revision 4313a2d8 (ceph): crush: don't warn on skipped types
- It's perfectly okay to skip some.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 12:01 AM Revision 56a6aa7a (ceph): osdmap: set 'default' pool type correctly
- Got this wrong in e85961167eb1f37f80f263257799e4e901d17e74
Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
04/03/2012
- 11:33 PM Revision dd7b84a5 (ceph): ceph-fuse: fix log reopen when -f is specified
- Don't restart if it wasn't stopped.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 10:56 PM Revision 1836d467 (ceph): Added assertion to check that targets > roles
- Signed-off-by: Mark Nelson <mark.nelson@dreamhost.com>
- 10:56 PM Revision 95294027 (ceph): nuke: don't run umount when no xargs args
- Gets rid of this noise:
INFO:teuthology.nuke:Unmount any osd data directories...
INFO:teuthology.orchestra.run.err:U... - 10:40 PM Revision e8596116 (ceph): osd: define more crush types
- We don't use these by default, but this way they are there should someone
want to use them.
Signed-off-by: Sage Weil... - 10:35 PM Revision 2dbdadbe (ceph): test_rewrite_latency: check return value
- Fixes warning
warning: test/test_rewrite_latency.cc:27:36: ignoring return value of ‘ssize_t pwrite(int, const void*... - 10:28 PM Revision 493344fd (ceph): Makefile: add mssing header
- Signed-off-by: Sage Weil <sage@newdream.net>
- 09:21 PM Revision d57d8af7 (ceph): rgw: throttle at num_threads * 2
- If we throttle at num_threads, then nothing gets into the workqueue until
a worker thread is idle, which means you pa... - 08:44 PM Revision 1ef37ab8 (ceph): Merge remote-tracking branch 'gh/msgr-api-changes'
- Reviewed-by: Sage Weil <sage@newdream.net>
- 08:41 PM Revision a31efd9c (ceph): filestore: print Sequencer name in debug output
- And clean it up just a bit.
Signed-off-by: Sage Weil <sage@newdream.net> - 08:22 PM Revision 756621d5 (ceph): msgr: clean up Pipe::do_sendmsg.
- Document it as with the tcp stuff, remove an if(0)'d debugging block,
and remove the useless "sd" parameter since it'... - 08:22 PM Revision 9f10a991 (ceph): msgr: write minimal documentation for the tcp functions.
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 08:22 PM Revision e966c39d (ceph): msgr: make a bunch of stuff private.
- Why were all these data members public? They're accessed by Pipes
and the Accepter and stuff, so maybe that's why...b... - 08:22 PM Revision 096971d4 (ceph): msg: update the Dispatcher and Messenger documentation
- Clarify what mark_down() and mark_down_on_empty() actually do.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.... - 08:21 PM Revision 36ec8e93 (ceph): dispatcher: fix documentation for ms_handle_reset
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 08:21 PM Revision cbe13ab2 (ceph): msgr: rename set_ip() -> set_addr_unknowns()
- The generic interface shouldn't reference specifics like that.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.... - 08:13 PM Revision 607f35e7 (ceph): msgr: Remove _my_name and ms_addr, replace with direct access to my_inst.
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 08:13 PM Revision 77f45667 (ceph): msgr: store the entity_inst_t in the Messenger.
- Convert ms_addr and _my_name to be references to their fields in
the entity_inst_t my_inst.
This way we can use const... - 08:11 PM Revision 6374d064 (ceph): buffer: implement a contents_equal function on bufferlists
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 08:11 PM Revision 5681461b (ceph): msgr: change the signature of get_myaddr()
- Return a const reference to the actual address, instead of copying it.
All current users are happy with this, and I c... - 08:11 PM Revision 45a76eaf (ceph): msgr: get_connection() is required to establish a connection if none ex...
- Making an allowance for lossy server connections is silly. Just don't
ask for the Connection in that case. (There are... - 08:10 PM Revision e80126ea (ceph): test: fix monmaptool help text
- Broken by commit:15f0a3270fdcf09acce554313f2d0c0814a511e4
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 06:32 PM Revision e06436e9 (ceph): cls_rgw: guard decode
- thee were few cases where decode wasn't guarded.
Signed-off-by: Yehuda Sadeh <yehuda.sadeh@dreamhost.com> - 06:30 PM Revision ebb487a6 (ceph): cls_rgw: reset return code in some cases
- Beforehand the return code was ignored, so fixed the cases
where we erroneously return error instead of success.
Sig... - 05:12 PM Revision a8938422 (ceph): librados: fix exec test
- Return for read operations is now returned correctly.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 04:06 PM Revision 57f52479 (ceph): doc: disable broken 'doxygenclass' class in librados c++ doc
- This is the last remaining gitbuilder error. Add it back when the C++
docs actually build.
Signed-off-by: Sage Weil... - 03:58 PM Revision 9d4fcd08 (ceph): Merge remote-tracking branch 'gh/stable'
- 03:44 PM Revision e40cf8ca (ceph): test_workload_gen: fix Sequencer ctor
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:04 AM Revision b5ca2fe0 (ceph): Merge remote-tracking branch 'gh/wip-name-sequencers'
- 05:03 AM Revision d70191a8 (ceph): Merge remote-tracking branch 'gh/wip-2087'
04/02/2012
- 08:24 PM Revision addc7446 (ceph): rgw: check for subuser existence
- This fixes #1856: looking up subuser that doesn't exist returns
user as long as subuser prefix defined existing user.... - 12:04 AM Revision e792cd93 (ceph): filestore: fix ZERO fallback write
- It helps if we write zeros!
Signed-off-by: Sage Weil <sage@newdream.net>
04/01/2012
- 11:24 PM Revision 8434caf5 (ceph): qa: test_rewrite_latency
- Tool to measure latency of overwriting a single block.
Signed-off-by: Sage Weil <sage@newdream.net>
03/31/2012
- 03:31 AM Revision dbc70b9d (ceph): Merge remote branch 'gh/wip-mon_setup'
- Reviewed-by: Sage Weil <sage@newdream.net>
- 03:18 AM Revision f8a53869 (ceph): osd: fix error code return from class methods
- Don't shadow the result at function scope.
Fixes: #2148
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 12:22 AM Revision 15f0a327 (ceph): monmaptool: make clear you can set the fsid when making a new map.
- Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
- 12:07 AM Revision 208daeb3 (ceph): ceph_mon: fix fsid parsing.
- fsid is a field in the CephContext _conf structure and is parsed by
the standard options parsing library before it ge...
03/30/2012
- 11:15 PM Revision 9a69c3f3 (ceph): ceph.conf: enable 'osd recover clone overlap'
- to test the recovery cloning in qa. this was redone, but forgot to enable
it in qa. - 11:14 PM Revision aa31035e (ceph): osd: update_stats() on reads too
- Update pg stats on any op completion (read or write), not just writes. Do
the calls with log_op_stats() for consiste... - 11:11 PM Revision 28788654 (ceph): log: dump_recent in fatal signal handler
- Signed-off-by: Sage Weil <sage@newdream.net>
- 11:07 PM Revision f27acbc8 (ceph): Merge remote-tracking branch 'gh/wip-log'
- Conflicts:
src/common/config_opts.h - 11:00 PM Revision 374bef9c (ceph): Merge remote branch 'gh/wip-osd-hb'
- 10:37 PM Revision f7f65ebe (ceph): osd: fix typo in debug message
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 09:57 PM Revision 75e3b9b3 (ceph): Merge remote branch 'gh/wip-osd-recovery-sources'
- 09:23 PM Revision df5860fe (ceph): objectstore: name Sequencers
- Assign a (unique) name to each Sequencer. This will aid in debugging, and
can be useful when dumping traces of FileS... - 06:57 PM Revision 29c01f25 (ceph): ceph_common.sh: Remove dead code.
- Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
- 06:27 PM Revision ba6bb4cf (ceph): man: Oops, update ceph-mon(8) for real. Sorry about that.
- Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
- 06:26 PM Revision 541a543c (ceph): man: Update ceph-mon(8) after reStructuredText syntax fixes.
- Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
- 06:16 PM Revision 2c542442 (ceph): doc: Remove duplicate anchor from (unused) overview doc.
- Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
- 06:11 PM Revision 1ec47db1 (ceph): doc: Convert the mailing list mention to not be a section heading.
- If toctree is inside a section, the subtree is inside the section too.
We don't want all of dev/* to be under "Mailin... - 06:11 PM Revision b162696b (ceph): doc: Fix reStructuredText syntax errors.
- Signed-off-by: Tommi Virtanen <tommi.virtanen@dreamhost.com>
- 05:52 PM Revision 2d1a96d3 (ceph): add include/stringify.h
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 04:59 PM Revision b25817a5 (ceph): FileJournal: check pwrite return value when zeroing journal
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 04:52 PM Revision 41f84fac (ceph): filestore: set guard on collection_move
- During recovery we submit transactions like:
- delete a/foo
- move tmp/foo to a/foo
This prevents the EEXIST chec... - 03:49 PM Revision f89f98df (ceph): osd: clear RECOVERING on start_peering_interval
- This prevents us from, say, getting into a recovering+stray state.
Signed-off-by: Sage Weil <sage@newdream.net> - 03:45 PM Revision 3cdd8d58 (ceph): osd: more heartbeat debug
- Signed-off-by: Sage Weil <sage@newdream.net>
- 03:45 PM Revision e1a58912 (ceph): osd: discard heartbeat_peer in note_down_osd
- Discard the heartbeat_peer as soon as we find out, along with queued
failures, or else the heartbeat_check may come a... - 03:45 PM Revision 21e6e2b8 (ceph): osd: ignore peer epoch of 0 on ping reply
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 03:45 PM Revision efc27f19 (ceph): osd: don't fail new heartbeat peers
- last_tx may be 0 because we just added this peer; don't mark them down
yet!
Signed-off-by: Sage Weil <sage.weil@drea... - 03:45 PM Revision 33b9187a (ceph): osd: rename hbin -> hbclient, hbout -> hbserver
- This is way less confusing.
Signed-off-by: Sage Weil <sage@newdream.net> - 03:44 PM Revision 4e2f0d14 (ceph): osd: simplify heartbeat logic
- Simplify heartbeats to use a simple request/reply model.
- avoid any weirdness with map update timing
- no from/to... - 03:44 PM Revision fe5f0331 (ceph): osd: send pings from hbin
- Fixes: #2212
Signed-off-by: Sage Weil <sage@newdream.net> - 02:32 PM Revision eebc9ec2 (ceph): test: test_workload_gen: Add callback for collection destruction.
- When we remove a collection, we must cleanup after the coll_entry_t we
once had on the available collections set. For... - 01:53 PM Revision 424b5b07 (ceph): ceph: --concise by default, add --verbose option
- It's time.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 03:31 AM Revision 409b648b (ceph): config: drop old debug_* items
- ...and replace code references with conf->subsys.should_gather().
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 02:16 AM Revision 5d981b15 (ceph): rgw: add unittest just to verify we link
- This will flush out references to stuff in libglobal.la, among other
things.
Signed-off-by: Sage Weil <sage.weil@dre... - 02:06 AM Revision 69b01726 (ceph): config: fix librados, libcephfs unit tests
- No more g_conf->debug.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 01:08 AM Revision 394d8b1e (ceph): Add test for object source marked down
- 01:08 AM Revision b4aa098f (ceph): make Thrasher not inherit from Greenlet
- 01:02 AM Revision 1c8ec702 (ceph): PG,ReplicatedPG: update missing_loc_sources with missing_loc
- In some cases missing_loc was updated without missing_loc_sources
Signed-off-by: Samuel Just <samuel.just@dreamhost.... - 01:02 AM Revision 05ef3ba6 (ceph): ReplicatedPG: fix loop in check_recovery_sources
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
03/29/2012
- 08:15 PM Revision 41a09bea (ceph): Merge remote branch 'upstream/wip_latency'
- 02:34 PM Revision c39ed568 (ceph): test: test_workload_gen: Fixing a memleak.
- Apparently, the FileStore does not cleanup after transactions once they
are applied, which may lead to huge memory le... - 05:47 AM Revision b3069e50 (ceph): ceph_argparse: drop useless declaration from unit test
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 12:16 AM Revision 4269f8d5 (ceph): ReplicatedPG: ctx might not contain an OpRequest
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 12:16 AM Revision 135a11ba (ceph): FileJournal: optionally zero journal on create
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 12:15 AM Revision 2486c61a (ceph): FileStore: Pass OpRequestRef into filestore in queue_transaction
- This allow us to track op progress through the filestore.
Signed-off-by: Samuel Just <samuel.just@dreamhost.com> - 12:15 AM Revision d026cdc7 (ceph): FileJournal: use DSYNC for directio path
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 12:15 AM Revision 533bbf7b (ceph): osd/: OpRequest implements TrackedOp for passing into filestore
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
03/28/2012
- 04:02 PM Revision 4f0d170a (ceph): test: test_workload_gen: Change CLI option and add '--help' usage.
- With this commit, we support the following options (and old ones are no
longer available):
--test-num-colls VAL ... - 03:34 PM Revision 18d219e5 (ceph): rgw: replace dout with ldout
- librgw can't use g_ceph_context
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 01:59 PM Revision a3bdf055 (ceph): test: test_workload_gen: Default arguments, and minor changes.
- Besides adding support for default arguments, passed onto global_init(),
this commit fixes a conflict in Makefile.am,... - 01:32 PM Revision 37cdbcd4 (ceph): log: fix up unittest
- Fewer entries; compile.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 02:58 AM Revision 94e3abf8 (ceph): Merge branch 'stable'
- 12:22 AM Revision 8948ad01 (ceph): test: test_workload_gen: CodeStyle compliance and cleanup.
- This commit aims at the compliance with Ceph's CodeStyle, as well
as cleaning up some lingering unused code.
Also, n... - 12:22 AM Revision d172b40c (ceph): test: test_workload_gen: Destroy collections.
- 12:22 AM Revision 3770096a (ceph): test: test_workload_gen: Mimic an OSD's workload.
- In it's current state, the workload generator will queue a lot of
transactions onto the FileStore, and will wait if n... - 12:18 AM Revision 749826c2 (ceph): allow use of a separate journal block device
03/27/2012
- 11:44 PM Revision ffc468f2 (ceph): osdmap: less noisy about osd additions during buildmap
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 11:44 PM Revision 36c2f27d (ceph): osdmaptool: fix clitest conf filename
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 11:37 PM Revision ca1f79b5 (ceph): dout: no newlines on dout_emergency
- Preserve old behavior to avoid breaking all the cli tests.
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 11:27 PM Revision d5360968 (ceph): throttle: fix off by one issue
- We were blocking only if we exceeded max count, not if
we reached it.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdrea... - 11:23 PM Revision a52d048a (ceph): rgw: throttle incoming requests
- Don't accept more than the number of threads, otherwise if cluster is
backed up for any reason we'd end up exhausting... - 11:16 PM Revision 30cadf01 (ceph): prebufferedstreambuf: fix typedef
- 'typename' not allowed here:
./common/PrebufferedStreambuf.h:27: error: using 'typename' outside of template
Signed... - 10:35 PM Revision 93ba4c00 (ceph): Merge branch 'wip-intent-fixes'
- 10:35 PM Revision ca4fab47 (ceph): Merge branch 'master' of ssh://github.com/ceph/ceph
- 10:35 PM Revision 16b60b3e (ceph): rgw: minor style fixes
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 10:12 PM Revision 4d74a7b2 (ceph): osd: fix handling of recovery sources when osds go down
- If a source osd goes down, we need to
- reset any pulls (already did that before)
- remove peer from missing_loc s... - 10:03 PM Revision 8fdde24c (ceph): osd: remove down osds from peer_*_requested maps
- This will leave less crap around to confuse recovery if a source osd goes
down and then up.
Signed-off-by: Sage Weil... - 10:02 PM Revision 1ee60873 (ceph): osd: maintain missing_loc_sources
- This is a superset of all missing_loc values... everywhere we might
pull an object from, or are currently pulling fro... - 09:37 PM Revision 5dbb9715 (ceph): rgw: all intent log operations are now async
- That includes removing a directory index object, and the removal of
the actual intent log object.
Signed-off-by: Yeh... - 09:20 PM Revision 0b1e3ed4 (ceph): osd: increase default heartbeat_interval to 6 seconds
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 09:12 PM Revision 69844496 (ceph): rgw: remove pool_list(), can't list_objects() on system buckets
- pool_list() was broken, replaced now with pool_iterate(). list_objects()
shouldn't be used any more with system bucke... - 09:04 PM Revision 2e9079cf (ceph): rgw: intent log processing uses new pool_iterate()
- intead of pool_list(), which is broken (assuming pgls results are
sorted, which are not).
Signed-off-by: Yehuda Sade... - 08:57 PM Revision 1814aac1 (ceph): Merge branch 'misc-fixes-for-review'
- 08:57 PM Revision d5c4015d (ceph): uclient: We want to release cache when we lose the CACHE cap, not gain it!
- Looks like this was detected as a problem back in
84644dc56183b67050793a1b8da07850508b29d6 but the fix wasn't complet... - 08:57 PM Revision c3b04644 (ceph): paxos: share_state sends every unknown value, including the stashed one
- Sage points out that the stashed object might not be the same as the
one we actually archive. For instance, OSDMonito... - 08:57 PM Revision 2acf4aea (ceph): mon: Paxos needs to store the latest version permanently on-disk.
- Previously it was only storing this m->latest_value in the stash,
which of course got overwritten. And then when some... - 08:57 PM Revision d0ba27ae (ceph): doc: add a short thing on kernel client troubleshooting.
- I just noticed this sitting uncommitted in my tree.
Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com> - 08:02 PM Revision c89b7f22 (ceph): v0.44.1
- 06:35 PM Revision 6044c5b8 (ceph): hadoop: define subsystem, fix logging
- Signed-off-by: Sage Weil <sage@newdream.net>
- 06:20 PM Revision ce61a83f (ceph): log: throttle message submission, trim recent
- Signed-off-by: Sage Weil <sage@newdream.net>
- 06:20 PM Revision fe56818e (ceph): config: configure log thresholds
- - max new entries before we wait for flush
- max recent entries to keep around
Signed-off-by: Sage Weil <sage@newdre... - 06:05 PM Revision 339956df (ceph): log: don't spam -1 to syslog; add err_to_syslog for consistency
- This matches the stderr settings.
Signed-off-by: Sage Weil <sage@newdream.net> - 05:44 PM Revision 17a95c22 (ceph): log: use PrebufferedStreambuf
- It's faster than ostringstream!
Signed-off-by: Sage Weil <sage@newdream.net> - 05:44 PM Revision bfa2bcd7 (ceph): prebufferedstreambuf: fix get_str()
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:43 PM Revision 0e3c0c44 (ceph): bench_log: flush
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:42 PM Revision 3a87e452 (ceph): log/EntryQueue: no implicit trim
- dequeue() things explicitly if you want to remove them.
Signed-off-by: Sage Weil <sage@newdream.net> - 05:41 PM Revision f66e0750 (ceph): utime_t: sprintf() method
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:41 PM Revision 6ab85264 (ceph): do_autogen: control optimization level
- -O 2 -> -O2
Signed-off-by: Sage Weil <sage@newdream.net> - 05:41 PM Revision a4509273 (ceph): common: add PrebufferedStreambuf
- Simple streambuf that uses a preallocated buffer, and then spills over
into a std::string if necessary.
Signed-off-b... - 05:41 PM Revision 23f0af3c (ceph): test log performance with PreallocatedStreambuf
- - faster than ostringstream in optimistic case
- same as ostreamstream + std::string assignment in worst case (use
... - 05:41 PM Revision 8c5046fa (ceph): bench_log: simple util to time how long it takes to log stuff
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:41 PM Revision 362ca19b (ceph): log: move create_entry() into Log interface
- This will let us be smarter than putting it on the heap.
Signed-off-by: Sage Weil <sage@newdream.net> - 05:41 PM Revision c7242bfe (ceph): log: flush on_exit
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:41 PM Revision abfadb9b (ceph): assert: dump recent log entries on failed assertions
- Signed-off-by: Sage Weil <sage@newdream.net>
- 05:41 PM Revision f41887e3 (ceph): log: new logging infrastructure
- - explicitly defined subsystems, and ceph_subsys_FOO enums to go with them
- modular log system with Entry object
- s...
03/26/2012
- 11:48 PM Revision 974a2013 (ceph): objecter: don't call op_throttle_ops.take(1) unconditionally
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 11:17 PM Revision 679cd1fe (ceph): objecter: add in-flight ops throttling
- In addition to ops length, we also want to throttle it by
actual number of ops.
Signed-off-by: Yehuda Sadeh <yehuda@... - 10:02 PM Revision d6b0cbd4 (ceph): config: use our assert
- Signed-off-by: Sage Weil <sage@newdream.net>
- 07:40 PM Revision c3dc6a6e (ceph): msg: assert pipe->msgr == msgr
- Fixes: #2216
Signed-off-by: Sage Weil <sage@newdream.net> - 06:57 PM Revision e30b7710 (ceph): rbd: fix typo in default config
- pyflakes would have caught this if 'all' weren't a built-in function
- 06:43 PM Revision 483fcf80 (ceph): doc: include crush in toctree
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 06:30 PM Revision 3bd1f18e (ceph): doc: few notes on manipulating the crush map
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 05:15 PM Revision 6db77158 (ceph): doc/dev/peering.rst: fix typo
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
- 04:39 PM Revision 1a0360cb (ceph): osd/: OpRequest is no longer a RefCountedObject, remove puts/gets
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 04:38 PM Revision ea377a08 (ceph): osd/: Convert OpRequest* to OpRequestRef
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 04:38 PM Revision 2cb6c7d0 (ceph): OSD: Add typedef for shared_ptr<OpRequest>
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 04:36 PM Revision 3ed784c9 (ceph): osd/: add mark_event to OpRequest and move tracking into OpTracker
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 03:28 AM Revision e478a758 (ceph): vstart: enable omap for xattrs
- Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
03/25/2012
- 03:05 PM Revision f4b2097a (ceph): Merge remote branch 'gh/wip-doc-peering'
- 02:57 PM Revision d3bcac24 (ceph): Makefile: fix modules that cannot find pk11pub.h when compiling with NS...
- Signed-off-by: Jim Schutt <jaschut@sandia.gov>
Signed-off-by: Sage Weil <sage.weil@dreamhost.com> - 02:57 PM Revision 3ab28950 (ceph): don't override CFLAGS
- leveldb adds -I flags to CFLAGS and CXXFLAGS, but if these macros are
overridden in the make command line, the flags ... - 04:47 AM Revision ef17c8c9 (ceph): add smoke suite
- This could probably be collapsed into a bunch of singleton tasks to make
it simpler to track how many actual jobs res... - 04:20 AM Revision b5641ef3 (ceph): rgw: don't #include fcgi from rgw_common.h
- ceph-dencoder #includes rgw_common.h, and needs to build even when
--without-radosgw is specified and libfcgi isn't i... - 04:09 AM Revision 1c1192a9 (ceph): backfill: use 'rbd' pool instead of 'data'
- (data has a replay interval, which makes writes take longer to resume
after repeering) - 04:09 AM Revision 397e7f2f (ceph): add osd_recovery task to test divergent osd logs
03/24/2012
- 11:07 PM Revision 24910c3b (ceph): add osd-recovery test
- 11:07 PM Revision 6bf9c957 (ceph): renamed backfill -> osd_backfill
- 11:05 PM Revision ca9a5a4a (ceph): rename backfill -> osd_backfill
- 10:36 PM Revision 22e80874 (ceph): put filestore xattr option in [global]
- ...for test_filestore_idempotent's benefit
03/23/2012
- 08:27 PM Revision 2ec8f27f (ceph): rados_bench: generate_object_name now takes a buffer length
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
Reviewed-by: Josh Durgin <josh.durgin@dreamhost.com>
03/22/2012
- 09:41 PM Revision 21a170e8 (ceph): doc: dev/peering.rst edits from Greg
- Signed-off-by: Sage Weil <sage@newdream.net>
- 03:33 PM Revision 8fa904a6 (ceph): doc: update dev/peering document
- - fix discussion of last epoch started
- define terms for current and past intervals
- describe role of pg info
- rem... - 02:55 PM Revision de867632 (ceph): msgr: fix tcp.cc linkage
- Signed-off-by: Sage Weil <sage@newdream.net>
- 02:53 PM Revision fd9935b7 (ceph): cephtool: don't prefix log items
- This just makes it hard to read them.
Signed-off-by: Sage Weil <sage@newdream.net>
03/21/2012
- 11:41 PM Revision 2e21adf2 (ceph): Objecter: resend linger_ops on any change
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
Reviewed-by: Josh Durgin <josh.durgin@dreamhost.com> - 11:35 PM Revision b47454b6 (ceph): ObjectStore: add COLLECTION_MOVE to dump
- Signed-off-by: Samuel Just <rexludorum@gmail.com>
- 11:35 PM Revision 23313ee6 (ceph): FileStore: whitelist COLLECTION_MOVE on replay
- Signed-off-by: Samuel Just <rexludorum@gmail.com>
- 11:35 PM Revision ec52eeb2 (ceph): FileStore: remove src on EEXIST during collection_move replay
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 11:35 PM Revision 52aff487 (ceph): ObjectStore: Add collection_move to generate_instances
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 09:01 PM Revision 3caa4319 (ceph): ceph: define and use a shell_scripts Makefile variable
- Define a variable "shell_scripts" in the Makefile.in, and use it
along with some pattern rules to avoid some duplicat... - 09:01 PM Revision 1b2a0669 (ceph): ceph-kdump-copy: add tools for saving kdumps
- This puts in place an init script and a command it runs to save a
kernel core dump to a remote server when a panic or... - 07:00 PM Revision 6f0f250b (ceph): suite: add missing print statement
- 06:58 PM Revision 8a9a5670 (ceph): suite: fix print statement when summary doesn't exist
- 01:30 PM Revision d0e8f148 (ceph): doc: update list of debian dists
- Signed-off-by: Sage Weil <sage@newdream.net>
- 01:28 PM Revision a608a8fe (ceph): Merge branch 'stable'
- 02:00 AM Revision 91c08f6e (ceph): Add watch op to rados.py
- Signed-off-by: Samuel Just <sam.just@dreamhost.com>
- 12:51 AM Revision 72361784 (ceph): Objecter: resend linger_ops on any change
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
Reviewed-by: Josh Durgin <josh.durgin@dreamhost.com> - 12:51 AM Revision 3019d460 (ceph): TestRados: Add watch
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
Reviewed-by: Josh Durgin <josh.durgin@dreamhost.com> - 12:20 AM Revision 2998368a (ceph): rgw: remove unused definition
- Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
- 12:20 AM Revision 4760536f (ceph): rgw: keep pool placement info also in cacheable location
- Mirror the pools placement info, so that we can cache it.
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 12:00 AM Revision f1563a66 (ceph): Revert "Objecter: add op->resend_on_any_change"
- This reverts commit c53194d75390dd6d5aa4a9a33f741cbd106e3338.
recalc_linger_op_target is used for linger_ops
Signed...
03/20/2012
- 11:11 PM Revision 2daff0e9 (ceph): ReplicatedPG: osd_max_notify_timeout -> osd_default_notify_timeout
- This setting should not override user specified timeout.
Signed-off-by: Samuel Just <samuel.just@dreamhost.com> - 11:11 PM Revision c53194d7 (ceph): Objecter: add op->resend_on_any_change
- lingers must be resent even if the primary does not change.
Signed-off-by: Samuel Just <samuel.just@dreamhost.com> - 11:11 PM Revision fc7a1bda (ceph): ReplicatedPG: return -EBUSY on delete for objects with watchers
- Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
- 10:15 PM Revision 6a5cbec3 (ceph): rgw: replace bucket_id generation
- bucket_id is now string: <global instance id>.<num> where
num is increasing monotonically within the current rgw
inst... - 06:41 PM Revision cdd5298d (ceph): v0.44
- 05:59 PM Revision e42fbb70 (ceph): rgw: process default alt args before processing conf file
- this fixes #2189
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 05:52 PM Revision e0b8f7a0 (ceph): rgw: process default alt args before processing conf file
- this fixes #2189
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 05:37 PM Revision 51a07339 (ceph): rgw: incrase socket backlog
- 20 is too small
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 05:25 PM Revision 5b331987 (ceph): rgw: fix internal cache api
- This fixes issue #2190
Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> - 02:50 PM Revision 815fc3e2 (ceph): suite: failed runs might not have durations
- This was one cause of emails not being sent - stale /tmp/cephtest dirs
fail without recording a duration.
03/19/2012
- 11:10 PM Revision f923b840 (ceph): OSD: do not hold obc lock in disconnect_session_watches
- ObjectContext::lock is used only for implementing read_lock and
write_lock. PG::lock is used to protect the ObjectCo... - 09:16 PM Revision a65d4136 (ceph): suite, coverage: use absolute dirs for isdir checks
- This fixes the results to wait for all jobs to complete again.
- 06:57 PM Revision bdb72c28 (ceph): filestore_idempotent: get coverage and coredumps
- 06:31 PM Revision 6c8db1a8 (ceph): suite: more results logging
Also available in: Atom