Project

General

Profile

Bug #17662

Updated by Loic Dachary almost 4 years ago

The return statement is missing when creating the journal space as regular file

<pre>
1925 if stat.S_ISREG(mode):
1926 if getattr(args, name + '_dev'):
1927 raise Error('%s is not a block device' % name.capitalize,
1928 getattr(args, name))
1929 self.type = self.FILE
</pre>



return is missing in the ceph-disk/main.py

So when we create the journal space we get the error:

<pre>
*Notice: /Stage[main]/Main/Node[osd]/Ceph::Osd[/dev/sdc]/Exec[ceph-osd-prepare-/dev/sdc]/returns: ceph-disk: Error: <built-in method capitalize of str object at 0x7fbca1acf180> /tmp/ramdisk/journal-sdc.journal is neither a block device nor regular file*
Error: /bin/true # comment to satisfy puppet syntax requirements
set -ex
if ! test -b /dev/sdc ; then
mkdir -p /dev/sdc
if getent passwd ceph >/dev/null 2>&1; then
chown -h ceph:ceph /dev/sdc
fi
fi
ceph-disk prepare /dev/sdc /tmp/ramdisk/journal-sdc.journal
udevadm settle
returned 1 instead of one of [0]
Error: /Stage[main]/Main/Node[osd]/Ceph::Osd[/dev/sdc]/Exec[ceph-osd-prepare-/dev/sdc]/returns: change from notrun to 0 failed: /bin/true # comment to satisfy puppet syntax requirements
set -ex
if ! test -b /dev/sdc ; then
mkdir -p /dev/sdc
if getent passwd ceph >/dev/null 2>&1; then
chown -h ceph:ceph /dev/sdc
fi
fi
ceph-disk prepare /dev/sdc /tmp/ramdisk/journal-sdc.journal
udevadm settle
returned 1 instead of one of [0]
</pre>


Back