Bug #9995: failing test_filelock - CephFS - Ceph

Actions

Copy link

Bug #9995

closed

failing test_filelock

Added by Greg Farnum over 9 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

High

Assignee:

Greg Farnum

Category:

Target version:

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

http://qa-proxy.ceph.com/teuthology/teuthology-2014-11-02_23:04:01-fs-next-testing-basic-multi/583589/

It's getting EAGAIN on the background_file.

Actions

Copy link

Updated by Zheng Yan over 9 years ago

Status changed from New to Won't Fix

it's a bug in old version of libfuse, it calls our setlk callback for both fcntl setlk and flock requests

Actions

Copy link

Updated by Greg Farnum over 9 years ago

Status changed from Won't Fix to 12

Is there something we can do as a workaround to prevent this blocking things? I expect people are going to use new ceph-fuse with old kernels. And our nightlies are going to keep turning up errors. :(

Oh, looking at it a bit more, you must mean that FUSE prior to 2.9 is translating flock calls into setlk calls? Why would that break our interfaces?

Actions

Copy link

Updated by Zheng Yan over 9 years ago

static void do_setlk_common(fuse_req_t req, fuse_ino_t nodeid,
                            const void *inarg, int sleep)
{       
        struct fuse_lk_in *arg = (struct fuse_lk_in *) inarg;
        struct fuse_file_info fi;
        struct flock flock;

        memset(&fi, 0, sizeof(fi));
        fi.fh = arg->fh;
        fi.lock_owner = arg->owner;

        if (arg->lk_flags & FUSE_LK_FLOCK) {
                int op = 0;

                switch (arg->lk.type) {
                case F_RDLCK:
                        op = LOCK_SH;
                        break;
                case F_WRLCK:
                        op = LOCK_EX;
                        break;
                case F_UNLCK:
                        op = LOCK_UN;
                        break;
                }
                if (!sleep)
                        op |= LOCK_NB;

                if (req->f->op.flock)
                        req->f->op.flock(req, nodeid, &fi, op);
                else    
                        fuse_reply_err(req, ENOSYS);
        } else {
                convert_fuse_file_lock(&arg->lk, &flock);
                if (req->f->op.setlk)
                        req->f->op.setlk(req, nodeid, &fi, &flock, sleep);
                else    
                        fuse_reply_err(req, ENOSYS);
        }
}

old libfuse does not recognize FUSE_LK_FLOCK. I think we can't do anything with this bug.

Actions

Copy link