Bug #9987
closedmon: min_last_epoch_complete tracking broken
0%
Description
When we moved to pulling pgmap values out of keys we broke the min_last_epoch_clean invalidation code.
I suspect this is why people see leveldb grow... and a mon restart fixes it?
Updated by Dan van der Ster over 9 years ago
BTW, we compact our dumpling mon leveldb without restarting. We do
ceph tell mon.0 compactand that can shrink the db from 25GB down to ~1GB. Maybe it would compact even further with this fix?
Updated by Joao Eduardo Luis over 9 years ago
I don't think this will help much with your case. This patch will allow the monitor to delete data that should be removed from the store. Compaction will only work to remove already deleted data. It may certainly help with disk usage footprint by reducing the amount of data the monitors keep at any given time, and compaction will certainly help blowing those extra MBs away.
However, I've been wondering if keeping this data around (especially if it's lots of data) hinders leveldb automated compaction. If that's true, then I think this patch could indeed help out a lot with your issues, and I would be happy to buy a microbrewery for sage so that he'd have a lifetime of free beer.
Updated by Samuel Just over 9 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Loïc Dachary over 9 years ago
- firefly backport https://github.com/ceph/ceph/pull/3220
Updated by Loïc Dachary about 9 years ago
- Status changed from Pending Backport to Resolved
- Backport changed from giant, firefly, dumpling to giant, firefly
min_last_epoch_complete was introduced by 208959a0dcacba40116730702021090a24865eb3 in v0.79, after dumpling: no need to backport to dumpling
Updated by Ken Dreyer over 8 years ago
- Regression set to No
For the record, the fix at https://github.com/ceph/ceph/pull/3220 shipped in v0.80.8.