Actions
Bug #9976
closedceph cli injectargs parsing broken
% Done:
0%
Source:
Q/A
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
looks like it was the recent -- handling that broke?
gnit:src (master) 09:11 AM $ ./ceph tell osd.0 injectargs --debug-ms 1
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
debug_ms=1/1
gnit:src (master) 09:11 AM $ ./ceph tell osd.0 injectargs -- --debug-ms 1
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
debug_ms=1/1 failed to parse arguments: --
^^^
gnit:src (master) 09:11 AM $ ./ceph tell osd.0 injectargs -- --no-debug-osd-op-order
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
failed to parse arguments: --,--no-debug-osd-op-order
^^
gnit:src (master) 09:11 AM $ ./ceph tell osd.0 injectargs --no-debug-osd-op-order
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
failed to parse arguments: --no-debug-osd-op-order
(this should fail)
ubuntu@teuthology:/a/sage-2014-10-29_13:51:08-rados-master-distro-basic-multi/578643
Updated by Dan Mick over 9 years ago
Maybe as simple as
--- a/src/ceph.in
+++ b/src/ceph.in
@@ -646,6 +646,8 @@ def main():
# -- means "stop parsing args", but we don't want to see it either
if '--' in childargs:
childargs.remove('--')
+ if '--' in injectargs:
+ injectargs.remove('--')
# special deprecation warning for 'ceph <type> tell'
# someday 'mds' will be here too
testing wider
Updated by Dan Mick over 9 years ago
close; needs "if injectargs and ..", but that seems good
Updated by Loïc Dachary over 9 years ago
I did not see this one, sorry about that.
Actions